XBMC hangs when reading a corrupt mp3 file

[Juan234]

A single corrupt mp3 file will hang xbmc while its performing a media scan. UI becomes unresponsive. When I tested on the xbox with Atlantis Beta 1, xbmc never recovered when attempting to do a library scan over the network. On Windows (Atlantis Beta 2) it seems to finish scanning the individual mp3 file (locally) after a few minutes. Attempting to play the file freezes xbmc too. After a few minutes, the error message is displayed: "Playlist playback aborted. Too many consecutive failed items"

I think the correct behavior would be to allow the user to abort at any time. And I wouldn't think it should take minutes to discover a file is unplayable, especially when it's stored locally on the hard drive.

[Juan234]

example corrupt mp3

[apanloco]

Fixes an infinite loop when playing a corrupt mp3, and a crash when seek information is unavailable, and minor cleanups in MP3Codec.cpp.

[spiff]

applied with some minor adjustments. thanks!

r15847