verify rev 18873 is permanent

[Nuka1195]

fixed: Ticket #5082 - TinyXML's SetCondenseWhitespace was used inconsistently across XBMC (and wasn't threadsafe). It is now defaulted to false, and we don't touch it.


before i change all my xml files, just want to make sure the change will be permanent.

this use to print on consecutive lines, now it skips a line. so i need to remove all & # 10 ; .

<label>line of text & # 10 ;
line 2 of text</label>

[Nuka1195]

this also affects visibility tags

i did this for readability
this use to work, now i have to have it on one line.

<visible>[StringCompare(Window.Property(CurrentView),200) + IsEmpty(Window.Property(36Hour3title)) ] |
[StringCompare(Window.Property(CurrentView),202) + IsEmpty(Window.Property(HBHHead1)) ] |
[StringCompare(Window.Property(CurrentView),203) + IsEmpty(Window.Property(Weekend3day)) ] |
[StringCompare(Window.Property(CurrentView),204) + IsEmpty(Window.Property(10DayHead1)) ]
</visible>

[spiff]

this is permanent. painful for a while but worth it in the end. it will make .nfo files easier to do for instance.

[jmarshall]

The visibility stuff shouldn't be a problem though I would think? I can easily make it ignore whitespace between operators if it doesn't work as-is.

[Nuka1195]

it wasn't working here until i put it all on one line. not a big deal. i only did it for readability.

what about an option in the visible tag?

<visible orred="true">

[jmarshall]

Nah - better just to allow the linebreaks in there - will look into it.

[jmarshall]

Try altering this (ln 157, GUIInfoManager.cpp):


strTest.TrimLeft(" ");
strTest.TrimRight(" ");


to this:


strTest.TrimLeft(" \t\r\n");
strTest.TrimRight(" \t\r\n");


and see if that does the trick.

Cheers,
Jonathan