[DVDplayer] Increase subs delay step

[ashlar]

Hi! The current 25ms step used for the subtitles resynch is really too precise. Even with fast repeat settings it still makes large adjustments very time consuming.

100ms steps give very precise results while being far more manageable in terms of updating speed.

I think it should be a simple modification and 100ms it's standard in mplayer and ZoomPlayer. MPC-HC has a 500ms default that is definitely too coarse.

Edit: also it would be really good to have some visual cues drawn on top of the video while changing the subtitles delay from a remote. Again, this is something pretty much all the media players I quoted above do (Kmplayer too).

[jmarshall]

Agreed that 25ms is too fine. Anyone else got any comments on a useful default other than 100ms?

It's line 94 in GUIDialogAudioSubtitleSettings.cpp if you're being adventurous :)

Cheers,
Jonathan

[ashlar]

90 (http://xbmc.org/forum/../trac/browser/trunk/XBMC/xbmc/GUIDialogAudioSubtitleSettings.cpp#L90) m_subtitleVisible = g_application.m_pPlayer->GetSubtitleVisible();
91 (http://xbmc.org/forum/../trac/browser/trunk/XBMC/xbmc/GUIDialogAudioSubtitleSettings.cpp#L91) AddBool(SUBTITLE_SETTINGS_ENABLE, 13397, &m_subtitleVisible);
92 (http://xbmc.org/forum/../trac/browser/trunk/XBMC/xbmc/GUIDialogAudioSubtitleSettings.cpp#L92) AddSlider(SUBTITLE_SETTINGS_DELAY, 22006, &g_stSettings.m_currentVideoSettings.m_SubtitleDela y, -g_advancedSettings.m_videoSubsDelayRange, 0.025f, g_advancedSettings.m_videoSubsDelayRange, "%2.3fs", true);
93 (http://xbmc.org/forum/../trac/browser/trunk/XBMC/xbmc/GUIDialogAudioSubtitleSettings.cpp#L93) OnSettingChanged(m_settings.size()-1);
94 (http://xbmc.org/forum/../trac/browser/trunk/XBMC/xbmc/GUIDialogAudioSubtitleSettings.cpp#L94) AddSubtitleStreams(SUBTITLE_SETTINGS_STREAM);
95 (http://xbmc.org/forum/../trac/browser/trunk/XBMC/xbmc/GUIDialogAudioSubtitleSettings.cpp#L95) AddButton(SUBTITLE_SETTINGS_BROWSER,13250);
96 (http://xbmc.org/forum/../trac/browser/trunk/XBMC/xbmc/GUIDialogAudioSubtitleSettings.cpp#L96) AddButton(AUDIO_SETTINGS_MAKE_DEFAULT, 12376);It's line 92, maybe? But, unfortunately, in any case I'm no programmer...
I see the logic but I don't know how to apply it, never done it before.

Ideally there should be a setting in advancedsettings.xml similar to<subsdelayrange>10</subsdelayrange> It could be <subsdelaystep>100</subsdelaystep> to keep the naming convention similar enough.

Regarding the visual cues? Would it be tough to implement? Considering that all major players (at least in the Windows space, but mplayer is Linux too) have it, I guess I'm not alone in finding it useful. Zoom Player does it best, as it shows inside a small graphic element in the upper right corner, which is part of the skin used (and stays only for a brief period, just to give you an indication without needing to open the whole GUI to understand "where you are").

[jmarshall]

The key is to get it skinnable. It's something we want to do eventually, but as with all things, there's not enough time.

Just change the 0.025f to 0.1f

[sho]

I tend to agree with the original poster.
How about changing the hardcoded default?
Given he tracs it.

[jmarshall]

r17476

[ashlar]

The key is to get it skinnable.Yup, I imagined so... that is why I mentioned me not being a programmer. I thought I could do the change for the hardcoded delay step (but thanks for doing it yourself, I was afraid of "breaking" something :)), but while I saw the need for the visual cues to be skinnable... I wouldn't know where to start from.