PDA

View Full Version : [PATCH] Fixed Settings->Music->Files->Look for thumbs on remote shares


mbuchoff
2008-11-07, 17:38
I had to take quite a few liberties to get this working. Let me know how things should work and I will fudge this patch to make it so.

I had to fix some code that rejects remote thumbnails without looking at this option.

Also, for some reason, the CreateThumbnail function in DllLoader displays a scrambled image for remote files, almost as if it only loaded a little bit of the image. CreateThumbnailFromMemory worked fine for JPEGs only.

For non JPEGs that happened to be named Folder.jpg (the thumbnail naming scheme requires a .jpg extension regardless of the file-type), CreateThumbnailFromMemory did not work right away. When I removed the XBMC code that tries to determine the file-type and replaced it with UNKNOWN so cxImage had the responsibility, everything went fine.

http://xbmc.org/trac/ticket/5290

jmarshall
2008-11-07, 23:41
Thanks for the patch - I'll comment in the trac ticket.