star_thoughts
2008-10-22, 05:36
Not sure if this is the right forum to post this in, but here goes.
On the two machines I run XBMC on (my HTPC is one, and a dev machine is the other), any time there is a VTS change on the dvd, the last couple of seconds of the current VTS gets skipped over and the next VTS is started. This usually doesn't effect the show/movie on the DVD, but it effects things like trailers, menu transitions and the little opening sequences they put on the anime DVDs I watch. In the code I noticed that the VTS change causes the demuxer(s) to reset, even though the VTS is still being processed (seams to be queued up). I took out the handling of DVDNAV_VTS_CHANGE and everything seams to work just fine (the demuxers are still getting reset, but they are doing so at the right time). Unfortunately I don't really know anything about video/audio processing and I'm not sure if what I did would cause any side effects.
I looked in Trac, but I couldn't find anything in there, and I figured other people would notice it more than I would. I then tried to create a ticket as the link at http://xbmc.org/development/ said I should, but I got an error stating I didn't have access rights to do so. So I'm just going to post the change here so that someone can look at it from http://pastebin.com/m51b80f59.
I basically removed the code by #ifdef'ing it for non-windows only builds (since I run windows).
On the two machines I run XBMC on (my HTPC is one, and a dev machine is the other), any time there is a VTS change on the dvd, the last couple of seconds of the current VTS gets skipped over and the next VTS is started. This usually doesn't effect the show/movie on the DVD, but it effects things like trailers, menu transitions and the little opening sequences they put on the anime DVDs I watch. In the code I noticed that the VTS change causes the demuxer(s) to reset, even though the VTS is still being processed (seams to be queued up). I took out the handling of DVDNAV_VTS_CHANGE and everything seams to work just fine (the demuxers are still getting reset, but they are doing so at the right time). Unfortunately I don't really know anything about video/audio processing and I'm not sure if what I did would cause any side effects.
I looked in Trac, but I couldn't find anything in there, and I figured other people would notice it more than I would. I then tried to create a ticket as the link at http://xbmc.org/development/ said I should, but I got an error stating I didn't have access rights to do so. So I'm just going to post the change here so that someone can look at it from http://pastebin.com/m51b80f59.
I basically removed the code by #ifdef'ing it for non-windows only builds (since I run windows).