PDA

View Full Version : .nfo url and <movie>


Wazee
2008-01-17, 14:57
Hi,

Using .nfo files and wanted to know if this is possible?

http://www.imdb.com/title/tt0457655
<movie>
<title>After the Wedding</title>
</movie>

I would like XBMC to lookup the movie then only replace the Title.

spiff
2008-01-17, 15:14
no

Wazee
2008-01-17, 15:20
ok, thanks. Would this be a feature in the future?

spiff
2008-01-17, 15:23
patch welcome

Wazee
2008-01-17, 15:26
Could you please point in the right direction to get started on this feature?

spiff
2008-01-17, 15:29
sure.

VideoInfoScanner.cpp. in RetrieveVideoInfo, there's a block that checks for nfo files. if it finds a <movie> tag it grabs info and does a continue. if it finds an url it grabs the url and skips some blocks (the checks happen in NFOFile.cpp). you need to change the logic to check for both, and in the case of an url make sure you call videoinfotag.load() on the additional xml block after the usual scan.

Wazee
2008-01-17, 15:31
ok, thank-you.

Gamester17
2008-01-17, 15:47
Know that you do not have to get the XDK to develop this as you today can compile XBMC for Linux, Mac OS X, and Windows/Win32 as well, see:
http://www.xboxmediacenter.com/wiki/?title=Development_Notes

Please submit the patch if you do:
http://www.xboxmediacenter.com/wiki/?title=HOW-TO_submit_a_patch

zac_haryy
2008-01-24, 23:04
I am going to be making nfo files for all of my movies so that it is directed to the correct movie on IMDb every time when scanned into the library. Since I was going to be doing this I was wondering if there is anyway to make the library database use a certain title for the movies also, that I would specify in the nfo file instead of it using the IMDb title.

jmarshall
2008-01-25, 01:06
Yes - see the online manual on XML-based nfo files.

J_K_M_A_N
2008-01-25, 02:47
Was it added to be able to use both JM? I think what the OP is saying is they would have the address to the IMDb page and they want to also use a custom title instead of whatever gets grabbed from IMDb. (Which is something I would love also ;) ) It was discussed here (http://xbmc.org/forum/showthread.php?t=30691) but I didn't think it was added.

Personally, I would love to use it that way but...not smart enough to add myself. :(

J_K_M_A_N

zac_haryy
2008-01-25, 05:44
Yes JKMAN this is exactly what I am wanting to do. Use a custom title instead of the one grabbed from IMDb. Is this possible?

Wazee
2008-01-28, 15:28
I had a look at the code and couldn't make heads or tails - not a programmer at all. So anyone out there with some programming knowledge could please have a look would be greatly appreciated by all XBMC users.

RockDawg
2008-01-28, 16:13
I also think this would be a very nice feature. There's a quite a few movies for which IMDb has different names than what I know them as.

coastal
2008-01-28, 22:32
I couldn't find VideoInfoScanner.cpp or NFOFile.cpp anywhere in the xbmc structure. Am i missing something? If someone points me in the right location i'll have a go at editing it.

I'll also change my movie cleaner to accept different movie names. For me this would fix foreign films and trilogies: raiders, evil dead etc.

Good idea.

spiff
2008-01-28, 23:14
they are cleverly hidden in xbmc/

wait, that's not cleverly hidden at all....................

szsori
2008-01-29, 01:28
Obfuscation at its finest... put something where everyone expects it to be and nobody finds it. :)

I'd like to see this functionality extended beyond the <title> tag so we can override the year, rating, etc. So the code would:

Check for IMDB links. If found, get the IMDB info.
Check for XML data. If found, loop through each tag and override the IMDB info.

You might have to ignore IMDB links inside the XML data, otherwise you might pick up on links that you don't intend it to process.

Wazee
2008-01-29, 07:43
Good to see this is picking up pace, greatly appreciated. One question - how often does the IMDB ratings change?

szsori
2008-01-30, 05:38
They change a lot for new/popular movies and very little for older/less-popular ones. It's just math.

Take Juno for example: http://imdb.com/title/tt0467406/
With 37,018 votes and a 8.4 rating, it would take an a few thousand 10 votes to change it to an 8.5.

For comparison, Untracable: http://imdb.com/title/tt0880578/
With 1290 votes and a 6.1 rating, it would take around 100 votes to change the rating.

By the time you get it into your library there will probably be at least a DVD Screener out for it, which means there will probably be a lot of votes. As a result even if the rating does change, it won't be a significant change. The obvious exception is if you watch really non-mainstream stuff... like lots of independent films.

zac_haryy
2008-01-30, 08:56
I am really glad to see that there are other people interested in this. I would love to have this implemented into the code. A lot of movies are named completely different then what I would want them to be named from IMDb.

SleepyP
2008-01-30, 20:56
Is there a way we can make this non-specific to a particular scraper? I was thinking that if this were actually going to be implemented, it'd be best to do it in such a way that the user could choose any scraper and have it work as expected. I THINk thats actually no big deal, since the stuff we are talking about applies to other stuff as well as IMDB.

As to the actual "how it works" side of things, my thoughts:
-I think that if the user has made the effort to put a specific URL into the NFO then thats what should be used for the lookup
-The scraper should iterate through each field to be populated, and check the NFO contents first. If there's something (even an empty field) in the NFO, then that should be used and the value should not be scraped from the web
-If a field is NOT contained in the NFO file, then the value is pulled from the web.

What do you guys think about handling info already present in the database? I think currently this operation is treated as a "refresh", so the current info in the database is removed / overwritten. Do you think this is the way things "should" be?

If we can get this function AND the "export to NFO/ TBN" functions coded then I think the video database will be about as good as it can be ;)

Wazee
2008-03-06, 06:42
Any updates? This would be a great benefit.

Wazee
2008-06-25, 15:05
I wanted to give this thread a bump. Could someone please have a look at this? Thanks.

midgetspy
2008-09-26, 22:52
I've never done any XBMC development but I'm a software engineer and proficient in C/C++ so I will look into implementing this feature... I'll try downloading and compiling the XBMC source this weekend.

Wazee
2008-10-12, 14:43
Hi midgetspy, how did you go?

sho
2008-10-12, 17:57
There is an outstanding feature request for this.
Hopefully some dev is willing to invest time in this for the next release (after Atlantis or 8.10).
http://xbmc.org/trac/ticket/4460

Wazee
2008-10-14, 03:06
Great, thanks. Would it be possible to add a link to this thread on the Feature Request?

jmarshall
2008-10-14, 03:30
You can do so if you wish, sure.

Wazee
2008-12-02, 11:38
Looks like this might have been added:
http://xbmc.org/trac/changeset/16386

Thank-You!