View Full Version : Multiple paths in a bookmark
i know this is the feature many of you have been waiting for. over the last two weeks, i silently added support for this to music as test. once its all sorted out, it can potentially be ported into video and pictures. i've been testing it myself for the time being and fixed a few issues i had introduced. so far, i can say it works as well as any other bookmark type. i even scanned my music thru one of these bookmarks. now, i need a larger community to test it.
it only accepts hard drive, samba, and xbms type paths. any others will be stripped while the configuration is read. it's built on top of the existing directory and file reading classes so all the wierd problems some people have with samba will be present here as well. i recommend using guest access or putting the workgroup and user details in the samba paths. it'll work otherwise, but it may be confusing if you're asked to provide user details for more than one samba path.
since comma is a valid character in samba and xbms, we cannot use comma seperated paths as the path definition. instead, i've added support for multiple paths in the true xml way:
<bookmark>
<name>music</name>
<path>e:\music</path>
<path>f:\music</path>
<path>smb://someserver/music</path>
<path>xbms://someotherserver:1400/music</path>
</bookmark>
you may have noticed in the changelog that this format is also now supported my programs bookmarks :)
what it does... it retrieves all the items from each of the defined paths and puts them into a single directory listing. it is a little slower because more than one path needs to be retrieved. and be careful with how many paths you use, and more importanty, how many items in each path. the xbox has limited memory, and will likely have problems if all the paths combined return 20,000 items.
what it does not do... it does not consolidate items that are named the identically into a single item. you can and will have more than one item with the same exact name.
known bugs... sorting doesnt work correctly. when sorting by name (the label of the items), sometimes items which are named identically are not next to each other.
MidKnight
2005-10-17, 05:48
you ripper!!, at this stage the music section for me is just one path, so ill be better to test this under video section where i can have many samba paths for music clips
you cant its not in video...
MidKnight
2005-10-18, 03:10
yes i know, im just waiting for you to add it
for those of you watching this space, here's an update...
after several hours, and lots of debug output, i can say that there is no sorting problem. no, its not fixed, its just not a sorting problem. list view always shows the correct ordering. thumbs view does not. i have to do more debugging.
and i said i'd been using this now for a while without any issues. that was true until last night. last night i was comfortable enough with the multipath bookmark that i removed all my old single path bookmarks which i had combined into the multipath one. this broke the multipath bookmark entirely. i have a fix but didnt commit it yet. it was really late at night, and i need to do some more testing before i commit it. (mostly to make sure that it doesnt break zip and rar support.)
in the meantime, make sure you have a normal bookmark that exactly matches the path of each of the paths in the multipath bookmark.
MidKnight
2005-10-19, 03:11
so it working for my viedeos ?
no. and i'll repeat myself. it's only in music for now, as a test.
great work kraqh3d! :bowdown:
ill make sure to test it out for music to see if i can help with any bugs
jc
i've been using this bookmark type exclusively now for music, and the sorting problem is really frustrating me. and i was totally wrong about listview being ok. the listview sometimes shows items in the wrong order too. i've confirmed that the sorting is definately using the item label, and not the path or anything else. i just dont get it.
kraqh3d,
any thoughts on when you will port this to videos and photos?
i'd say do it... maybe you'll figure out the sorting issue along the way.
soon... probably in another week or two.
the sorting problem is a bit of an annoyance but that's all it is. i'm most concerned about the other code changes to the music files window to in order to support the multipath bookmarks. this code is used regardless of if you are using multipath bookmarks or not. a couple of the bugs turned up which i corrected. i want it to bake in for a little bit longer before i retrofit the other windows.
when i do, i plan on doing pictures first since its the most basic media window. (i really should've introduced it here, but i was very familiar with its music's interworkings, and i personally had a need for it in the music window.)
video will come later. i forsee some challenges because of how stacking works. i need to take a careful look at that first.
video will come later. *i forsee some challenges because of how stacking works. *i need to take a careful look at that first.
video is actually the one i want the most... i have videos split between xbox and server.
suggestions on stacking...
maybe have it read all the paths first, compile the list, then run it through the stacking filter.
or
only have it stack on a per path basis.
i cannot think of why anyone would split the same video pairs between paths... just does not make sense.
stacking is applied after the directory items are fetched. the same would hold true for a multipath bookmark because of how its coded...
i took advantage our ingenious filesystem plug-in system to virtualize the fact that the bookmark has more than one path from the window. it doesnt know, nor does it care. what happens behind the scenes, is when the multipath bookmark is read in, its transformed into a new special path that represents the toplevel virtual path. (this all happens transparent to the user, of course. though i just thought of something that i need to add as a precaution.)
what i need to examine is how the stacking regexps work. i'd like to prevent stacking across paths to prevent incorrect stackings. i need to see if the regexp uses the full path, or just the filename. if it uses the full path, then it shouldnt matter, and it'll work how i want. but if it just uses the filename, then i'd need to make some changes to stacking as well.
Blackally
2005-11-14, 17:49
any news on this feature ??
peter
not really. the feature exists solely in music and has not changed signifigantly since its first introduction.
MidKnight
2005-11-15, 03:04
hungrly awaiting for it under videos
VelcroFly
2005-11-17, 13:29
i too appreciate your efforts and are anxiously awaiting any developments under my videos.
me too, this is going to be so sweet once its in video.
if you want some testing done on this for videos at any point, send me the code patch. i'd be happy to compile this and try it out. i use xbmc a lot and nearly everything i play would be through a multiple path bookmark, if this option was there, so could give it some pretty serious testing.
:d
i've been very busy with work the last few weeks, and will for the next few weeks. i will get to it, eventually.
cool, thanks for the update.
VelcroFly
2005-11-24, 04:25
hey man, no pressure here.
get to it when it moves you, do it for the right reason.
i'm getting what i paid for :thumbsup:
andy_dope
2005-11-25, 10:47
* * * *<bookmark>
* * * * * *<name>movie-streams</name>
* * * * * *<path>smb://workgroup;andy dope:pass@192.168.1.8/movies i</path>
* * * * * *<path>smb://workgroup;andy dope:pass@192.168.1.8/movies ii</path>
* * * * * *<path>smb://workgroup;andy dope:pass@192.168.1.8/movies iii</path>
* * * * * *<path>smb://workgroup;andy dope:pass@192.168.1.36/movies v</path>
* * * *</bookmark>
ok... thats what my bookmark is setup like works great when i click on my videos it goes straight to listing all my shares on one screen. *but when i enter a share and try and go back i have to go back 2 screens just to select the virtual path again. *any way to make the b button go back to the virtual path and not the actual path your in? *thanks.
MidKnight
2005-11-25, 11:33
since when was multi paths in my videos working?
it doesnt work cuz it's not finished. it'll read in the config, and will present you the virtualpath, but the navigation is all screwed up. for now, it only works correctly in music.
for those of you who have been waiting for multipath bookmarks, here it is. it now works, but i have to warn you that this is still very experimental. use it at your own risk.
it also fixes a navigational issue with the recently added playlists button in my video files. i only did preliminary tests to confirm that the navigation works as it should. two things to be weary of:
- i have no idea how this will work in conjunction with stacking (assuming that there are files in the root of your paths.)
- i dont know how well xbmc will cope with starting a slide show from the multipath listing. it *should* work but i have not explicitly tested this.
those of you who choose to try it out, please post your experiences here, especially if it deals with the two items above. i, however, may not get time to fix any bugs issues for a while. i didnt really notice the sorting, but i expect the problem still exists.
i know you have mentioned an issue with sorting but don't know if you have seen this but after your pics/vids multi path patch which i dont use personally anyway but kudos for the code kraqh3d.
the filesize of the videos no longer displays under 'ort by : name' <default> "until" you flick through the 'sort by' button. once your back at the 'sort by : name' <default> they display? then flick out of video back to menu and traight back to videos view and back to square one :)
not a major issue but a bug none the less!
i'm using the multipath bookmark, but i have a problem.
i have it setup like this:
* <!-- my videos shares !-->
* *<video>
* * * *<default></default>
* * * *<bookmark>
* * * * * *<name>1. film (not seen)</name>
* * * * * * <path>smb://gæst:xxxx@192.168.1.3/notseend/</path>
<path>smb://gæst:xxxx@192.168.1.3/notseene/</path>
* * * *</bookmark>
* * * *<bookmark>
* * * * * *<name>2. film (seen)</name>
* * * * * * <path>smb://gæst:xxxx@192.168.1.3/seend/</path>
<path>smb://gæst:xxxx@192.168.1.3/seene/</path>
* * * *</bookmark>
* * * *<bookmark>
* * * * * *<name>3. tv serier</name>
* * * * * * <path>smb://gæst:xxxx@192.168.1.3/seriesd/</path>
<path>smb://gæst:xxxx@192.168.1.3/seriese/</path>
<path>smb://gæst:xxxx@192.168.1.3/seriesf/</path>
<path>smb://gæst:xxxx@192.168.1.3/seriesg/</path>
* * * *</bookmark>
* *</video>
when i navigate to a "multipath bookmark"(mb) it works just great, and i can navigate back to the original "my video shares"
but the problem appears when i navigate to a mb and then further to a subfolder and back, it doesn't go to "my video shares" it goes to the share and not the mb.
ex: "my video share" -> "1. film (not seen)" -> "subfolder" and then when i press back i get to "smb://gæst:xxxx@192.168.1.3/notseend/"
and back again and i get to all the shares of that computer.
i don't know if it's supposed to do that, but i would like it better if i could get back to "my video shares" :)
edit:
i have tested a bit more and it seems the only way i can get back to "my videos" if i have been in a subfolder is this way:
my videos -> 1. film (not seen) -> subfolder
<-
share
<-
list of that computers shares
<-
list of workgroups
-> into my workgroup -> into my computer(with all the shares)
<-
back to workgroups
<-
back "my videos" wuuhuuu i'm back :)
thank you very much, i have been waiting for this since the beginning.
my feedback.
1.
in my video mb (multipath bookmark) if you select anything to play (there are no sub folders under the mb) and then stop it, then select ".." to get back to the parent folder it just loads the mb again. the "back" button on the remote works though.
if you enter the mb and dont select anything the ".." takes you to the parent folder. the "back" button on the remote works though.
here is a log of me entering the mb,
29-11-2005 00:10:17 info activating window id: 10006
29-11-2005 00:10:17 info attempting to default to:
29-11-2005 00:10:17 info loading skin file: myvideo.xml
29-11-2005 00:10:17 debug cguiwindowvideofiles::getdirectory ()
29-11-2005 00:10:17 debug parentpath = []
29-11-2005 00:10:17 debug fetching directory ()
29-11-2005 00:10:18 debug current m_vecpathhistory:
29-11-2005 00:10:18 debug 00.[]
29-11-2005 00:10:22 debug cguiwindowvideofiles::getdirectory (virtualpath://video/movies all)
29-11-2005 00:10:22 debug parentpath = []
29-11-2005 00:10:22 debug fetching directory (virtualpath://video/movies all)
29-11-2005 00:10:22 debug cvirtualpathdirectory::getdirectory(virtualpath://video/movies all)
29-11-2005 00:10:22 debug cvirtualpathdirectory::gettypeandbookmark(virtualp ath://video/movies all) = [video],[movies all]
29-11-2005 00:10:23 info loading skin file: dialogprogress.xml
29-11-2005 00:10:23 debug getting directory (smb://xbox:xbox@192.168.0.2/0-c)
29-11-2005 00:10:23 debug getting directory (smb://xbox:xbox@192.168.0.2/d-l)
29-11-2005 00:10:23 debug getting directory (smb://xbox:xbox@192.168.0.2/m-z)
29-11-2005 00:10:29 debug current m_vecpathhistory:
29-11-2005 00:10:29 debug 00.[]
29-11-2005 00:10:29 debug 01.[virtualpath://video/movies all]
then selecting ".."
29-11-2005 00:12:27 debug cguiwindowvideofiles::getdirectory ()
29-11-2005 00:12:27 debug parentpath = [virtualpath://video/movies all]
29-11-2005 00:12:27 debug fetching directory ()
29-11-2005 00:12:27 debug current m_vecpathhistory:
29-11-2005 00:12:27 debug 00.[]
29-11-2005 00:12:27 debug 01.[virtualpath://video/movies all]
29-11-2005 00:12:27 debug 02.[]
then entering mb again
29-11-2005 00:13:34 debug cguiwindowvideofiles::getdirectory (virtualpath://video/movies all)
29-11-2005 00:13:34 debug parentpath = []
29-11-2005 00:13:34 debug fetching directory (virtualpath://video/movies all)
29-11-2005 00:13:34 debug cvirtualpathdirectory::getdirectory(virtualpath://video/movies all)
29-11-2005 00:13:34 debug cvirtualpathdirectory::gettypeandbookmark(virtualp ath://video/movies all) = [video],[movies all]
29-11-2005 00:13:34 info loading skin file: dialogprogress.xml
29-11-2005 00:13:34 debug getting directory (smb://xbox:xbox@192.168.0.2/0-c)
29-11-2005 00:13:34 debug getting directory (smb://xbox:xbox@192.168.0.2/d-l)
29-11-2005 00:13:35 debug getting directory (smb://xbox:xbox@192.168.0.2/m-z)
29-11-2005 00:13:40 debug current m_vecpathhistory:
29-11-2005 00:13:40 debug 00.[]
29-11-2005 00:13:41 debug 01.[virtualpath://video/movies all]
29-11-2005 00:13:41 debug 02.[]
29-11-2005 00:13:41 debug 03.[virtualpath://video/movies all]
then playing a movie and stopping a movie
29-11-2005 00:14:57 debug item: smb://xbox:xbox@192.168.0.2/0-c/2 fast 2 furious.avi
29-11-2005 00:14:57 info mplayer play:smb://xbox:xbox@192.168.0.2/0-c/2 fast 2 furious.avi cachesize:8192
29-11-2005 00:14:59 debug msg: set audio functions called
29-11-2005 00:14:59 debug msg: done
29-11-2005 00:14:59 info flipping bi-directional subtitles disabled
29-11-2005 00:14:59 debug msg:mplayer_init()
29-11-2005 00:14:59 debug msg:enable mplayer osd
29-11-2005 00:14:59 debug msg:mplayer dev-cvs-051007-22:19-3.4.4 (c) 2000-2004 mplayer team
29-11-2005 00:14:59 debug msg:cpu: intel celeron 2/pentium iii coppermine,geyserville
29-11-2005 00:14:59 debug msg:(family: 6, stepping: 10)
29-11-2005 00:14:59 debug msg:detected cache-line size is 32 bytes
29-11-2005 00:14:59 debug msg:cpuflags: mmx: 1 mmx2: 1 3dnow: 0 3dnow2: 0 sse: 0 sse2: 0
29-11-2005 00:14:59 debug msg:compiled for x86 cpu with extensions:
29-11-2005 00:14:59 debug msg: mmx
29-11-2005 00:14:59 debug msg: mmx2
29-11-2005 00:14:59 debug msg: sse
29-11-2005 00:14:59 debug msg:
29-11-2005 00:14:59 debug msg:
29-11-2005 00:15:00 debug msg:creating config file: q:\system\players\mplayer\config
29-11-2005 00:15:00 debug msg:
29-11-2005 00:15:00 debug msg:88 audio & 199 video codecs
29-11-2005 00:15:00 debug msg:mplayer_open_file(smb://xbox:xbox@192.168.0.2/0-c/2 fast 2 furious.avi)
29-11-2005 00:15:00 info stating file smb://xbox:xbox@192.168.0.2/0-c/2 fast 2 furious.avi.conf
29-11-2005 00:15:00 info stating file q:\system\players\mplayer\2 fast 2 furious.avi.conf
29-11-2005 00:15:00 debug msg:playing smb://xbox:xbox@192.168.0.2/0-c/2 fast 2 furious.avi.
29-11-2005 00:15:00 debug msg:find subtitles
29-11-2005 00:15:00 debug msg:auto open z:\subtitle
29-11-2005 00:15:00 info loading skin file: dialogprogress.xml
29-11-2005 00:15:00 debug msg:protocol:smb
29-11-2005 00:15:00 debug msg:use standard file for protocol:smb
29-11-2005 00:15:00 debug msg:option stream url: this url doesn't have a username part.
29-11-2005 00:15:01 debug msg:option stream url: this url doesn't have a hostname part.
29-11-2005 00:15:01 debug msg:
cache fill: 0.00% (0 bytes)
29-11-2005 00:15:01 debug msg:
cache fill: 3.91% (327680 bytes)
29-11-2005 00:15:01 debug msg:
cache fill: 9.38% (786432 bytes)
29-11-2005 00:15:01 debug msg:
cache fill: 13.28% (1114112 bytes)
29-11-2005 00:15:01 debug msg:
cache fill: 17.97% (1507328 bytes)
29-11-2005 00:15:01 debug msg:avi file format detected.
29-11-2005 00:15:02 debug msg:video: [divx] 624x256 24bpp 25.000 fps 805.6 kbps (98.3 kbyte/s)
29-11-2005 00:15:02 debug msg:starting lookup for subs
29-11-2005 00:15:02 debug msg:global subsize: 0 - vobsub: -1, demux: -1, subs: -1
29-11-2005 00:15:02 debug msg:global subpos : -1
29-11-2005 00:15:02 debug msg:============================================== ============================
29-11-2005 00:15:02 debug msg:opening audio decoder: [mp3lib] mpeg layer-2, layer-3
29-11-2005 00:15:02 debug msg:audio: 48000 hz, 2 ch, 16 bit (0x10), ratio: 16000->192000 (128.0 kbit)
29-11-2005 00:15:02 debug msg:selected audio codec: [mp3] afm:mp3lib (mp3lib mpeg layer-2, layer-3)
29-11-2005 00:15:02 debug msg:============================================== ============================
29-11-2005 00:15:02 debug msg:============================================== ============================
29-11-2005 00:15:02 debug msg:opening video decoder: [ffmpeg] ffmpeg's libavcodec codec family
29-11-2005 00:15:02 debug msg:selected video codec: [ffodivx] vfm:ffmpeg (ffmpeg mpeg-4)
29-11-2005 00:15:02 debug msg:============================================== ============================
29-11-2005 00:15:02 debug msg:checking audio filter chain for 48000hz/2ch/16bit -> 48000hz/6ch/16bit...
29-11-2005 00:15:02 debug msg:af_pre: af format: 2 bps, 2 ch, 48000 hz, little endian signed int
29-11-2005 00:15:02 debug msg:af_pre: 48000hz 2ch signed 16-bit (little-endian)
29-11-2005 00:15:03 debug msg:ao: [win32] 48000hz 2ch signed 16-bit (little-endian) (2 bps)
29-11-2005 00:15:03 debug msg:building audio filter chain for 48000hz/2ch/16bit -> 48000hz/2ch/16bit...
29-11-2005 00:15:03 debug msg:starting playback...
29-11-2005 00:15:03 debug msg:mplayer_open_file(smb://xbox:xbox@192.168.0.2/0-c/2 fast 2 furious.avi) done 1.0000
29-11-2005 00:15:03 debug playback has started
29-11-2005 00:15:03 info activating window id: 12005
29-11-2005 00:15:03 notice start led control
29-11-2005 00:15:03 info loading skin file: videofullscreen.xml
29-11-2005 00:15:03 info loading skin file: videoosd.xml
29-11-2005 00:15:03 info loading skin file: videoosdsettings.xml
29-11-2005 00:15:04 debug cguiinfomanager::setcurrentmovie(smb://xbox:xbox@192.168.0.2/0-c/2 fast 2 furious.avi)
29-11-2005 00:15:04 info msg:[mpeg4 @ 013f4fc8]
29-11-2005 00:15:04 info msg:looks like this file was encoded with (divx4/(old)xvid/opendivx) -> forcing low_delay flag
29-11-2005 00:15:04 debug msg:vdec: vo config request - 624 x 256 (preferred csp: planar yv12)
29-11-2005 00:15:04 debug msg:vdec: using planar yv12 as output csp (no 0)
29-11-2005 00:15:04 debug msg:movie-aspect is undefined - no prescaling applied.
29-11-2005 00:15:04 debug msg:vo: [directx] 624x256 => 624x256 planar yv12
29-11-2005 00:15:04 info created yuv texture
29-11-2005 00:15:04 debug created yv12 texture 0
29-11-2005 00:15:04 debug msg:ffrw:normal play
29-11-2005 00:15:05 debug filecurl::close(d00e6d18)
29-11-2005 00:15:08 debug msg: mplayer_close_file()
29-11-2005 00:15:08 debug msg:
29-11-2005 00:15:08 debug msg: uninit_player
29-11-2005 00:15:08 debug deleted yv12 texture (0)
29-11-2005 00:15:08 debug deleted yuv video texture
29-11-2005 00:15:08 debug msg: uninit_player - done
29-11-2005 00:15:08 debug freeing fs segment @ 0x768220
29-11-2005 00:15:08 debug setting resolution 6
29-11-2005 00:15:08 debug we set resolution 6
29-11-2005 00:15:08 info loading skin file: myvideo.xml
29-11-2005 00:15:09 debug cguiwindowvideofiles::getdirectory (virtualpath://video/movies all)
29-11-2005 00:15:09 debug parentpath = [virtualpath://video/movies all]
29-11-2005 00:15:09 debug fetching directory (virtualpath://video/movies all)
29-11-2005 00:15:09 debug cvirtualpathdirectory::getdirectory(virtualpath://video/movies all)
29-11-2005 00:15:09 debug cvirtualpathdirectory::gettypeandbookmark(virtualp ath://video/movies all) = [video],[movies all]
29-11-2005 00:15:09 info loading skin file: dialogprogress.xml
29-11-2005 00:15:09 debug getting directory (smb://xbox:xbox@192.168.0.2/0-c)
29-11-2005 00:15:09 debug getting directory (smb://xbox:xbox@192.168.0.2/d-l)
29-11-2005 00:15:10 debug getting directory (smb://xbox:xbox@192.168.0.2/m-z)
29-11-2005 00:15:15 debug current m_vecpathhistory:
29-11-2005 00:15:16 debug 00.[]
29-11-2005 00:15:16 debug 01.[virtualpath://video/movies all]
29-11-2005 00:15:16 debug 02.[]
29-11-2005 00:15:16 debug 03.[virtualpath://video/movies all]
29-11-2005 00:15:16 notice start led control
then pressing ".." to get back to the parent folder
29-11-2005 00:16:21 debug cguiwindowvideofiles::getdirectory (virtualpath://video/movies all)
29-11-2005 00:16:21 debug parentpath = [virtualpath://video/movies all]
29-11-2005 00:16:21 debug fetching directory (virtualpath://video/movies all)
29-11-2005 00:16:21 debug cvirtualpathdirectory::getdirectory(virtualpath://video/movies all)
29-11-2005 00:16:21 debug cvirtualpathdirectory::gettypeandbookmark(virtualp ath://video/movies all) = [video],[movies all]
29-11-2005 00:16:21 info loading skin file: dialogprogress.xml
29-11-2005 00:16:21 debug getting directory (smb://xbox:xbox@192.168.0.2/0-c)
29-11-2005 00:16:21 debug getting directory (smb://xbox:xbox@192.168.0.2/d-l)
29-11-2005 00:16:22 debug getting directory (smb://xbox:xbox@192.168.0.2/m-z)
29-11-2005 00:16:27 debug current m_vecpathhistory:
29-11-2005 00:16:27 debug 00.[]
29-11-2005 00:16:27 debug 01.[virtualpath://video/movies all]
29-11-2005 00:16:27 debug 02.[]
29-11-2005 00:16:28 debug 03.[virtualpath://video/movies all]
then pressing "back" on the remote
29-11-2005 00:17:28 debug cguiwindowvideobase::goparentfolder(), strparent = []
29-11-2005 00:17:28 debug cguiwindowvideofiles::getdirectory ()
29-11-2005 00:17:28 debug parentpath = [virtualpath://video/movies all]
29-11-2005 00:17:28 debug fetching directory ()
29-11-2005 00:17:29 debug current m_vecpathhistory:
29-11-2005 00:17:29 debug 00.[]
29-11-2005 00:17:29 debug 01.[virtualpath://video/movies all]
29-11-2005 00:17:29 debug 02.[]
2.
the imdb thumbs do not show up in icon view. they do in the non-mb but not in the mb. if i press "info" all the imdb info is displayed though encluding thumbs
3.
no.2 might be affecting why mb's dont remember which view, icon, list, big icon. seems to always default to "list view"
4.
after entering and leaving a few bookmarks your log has the following in it, not sure but i dont think this is supposed to happen. and it grows...
29-11-2005 00:32:29 debug 00.[]
29-11-2005 00:32:29 debug 01.[virtualpath://video/movies all]
29-11-2005 00:32:29 debug 02.[]
29-11-2005 00:32:29 debug 03.[virtualpath://video/movies all]
29-11-2005 00:32:29 debug 04.[]
29-11-2005 00:32:29 debug 05.[smb://xbox:xbox@192.168.0.2/0-c]
29-11-2005 00:32:29 debug 06.[]
29-11-2005 00:32:29 debug 07.[virtualpath://video/movies all]
29-11-2005 00:32:29 debug 08.[]
29-11-2005 00:32:29 debug 09.[smb://xbox:xbox@192.168.0.2/0-c]
29-11-2005 00:32:29 debug 10.[]
29-11-2005 00:32:29 debug 11.[virtualpath://video/movies all]
29-11-2005 00:32:29 debug 12.[]
29-11-2005 00:32:30 debug 13.[virtualpath://video/movies all]
5.
sorting seems to work well, i tried all the options both forwards and reverse and it seemed to get it right.
6.
stacking seemed to work but i dont have any files stacked across hdd volumes.
7.
dont use playlists so no comment there.
thanks for the responses.
i'm pretty sure i know whats wrong with the navigation. the ".." item is processed differently than the "back" action. it seems like i missed it. please test in music if possible as a comparison.
that debug info is the current path history. i left that in there to debug navigation problems like this. those blank ones [] mean you're at the root bookmark listing. since ".." isnt being handled correctly, your getting the root listing. if you use the remote, you shouldnt see those blank ones.
i discovered this little anomaly when i did music. upon certain failures, the root bookmark listing is returned. the code was like that long before i put in this support. i didnt want to change that behaviour since it could potentially break everything else. so, i did my best to work around it.
thumbs, unfortunately, are affected by this change. because xbmc now sees a new virtual directory, the caching algorithm will return a different hash value. local folder.jpg thumbs should still be found and be recached, but images gotten from imdb will likely not work unless you look them up again from the new virtual path. a further level in, however, should work the same, provided, of course, that your path statements exactly match an old normal one.
i'm not sure why its defaulting to list view. this change does not change anything related to how the views work. its just virtual directory processing. can anyone else confirm this behaviour?
i'll try to fix the ".." problem in a day or two. that should be a quick fix.
** edit ** spiff was kind enough to throw in the ".." fix for me.
i'm 99% sure that this bug relates to the new bookmark code thus being the reason i post here.
under my videos there filesizes seem to have vanished?
press the 'name' sort button throught date, size etc... until you get to name and they come back? press back then enter videos again and there gone again.
tried different skin before posting this... and to no avail. noticed a bit of code about onsort? could this be the little blighter causing problems.
apologies : double post by me... must have had one to many the other day!
dean,
yeah. in guiwindowvideofiles.cpp, add "formatitemlabels();" right above "sortitems(m_vecitems);" underneath where i added the comment on onsort() being removed. (its in updatedir()). that should fix the issue.
i'm at work right now, so if any dev sees this, feel free to commit this change :)
hey thanks kraqh3d - i'm learning slowly :) that's 2 in 2 days... *:thumbsup:
guiwindowvideofiles.cpp
------------------------
// changed this from onsort() because it was incorrectly selecting
// the wrong item!
formatitemlabels(); <-- add this code @ line 426
sortitems(m_vecitems);
m_viewcontrol.setitems(m_vecitems);
yes, thats right. please confirm that works. (it should. that function sets the text in the right column based on the sort method.)
bug confirmed, fix confirmed, commit confirmed.
edit: typos
the thumbs are still not working. i picked a movie i havent imdb'd yet and looked it up from within the mb. it found the movie fine, downloaded its plot etc and even downloaded the thumb ( i verified that it was in the imdb folder) yet when you select icon view in the mb it doesnt show the thumb, info on the movie shows the thumb fine.
possibly the hash isnt working right (just guessing)
here is a log of me doing a look up etc..
01-12-2005 00:01:39 info loading skin file: dialogprogress.xml
01-12-2005 00:01:39 warning kernel32.dll fake function disablethreadlibrarycalls called
01-12-2005 00:01:39 info get url: http://akas.imdb.com/tsearch?title=yojimbo
01-12-2005 00:01:40 info 302 redirected: http://akas.imdb.com/find?q=yojimbo;s=tt
01-12-2005 00:01:41 info loading skin file: dialogselect.xml
01-12-2005 00:01:44 info loading skin file: dialogprogress.xml
01-12-2005 00:01:44 info get url: http://akas.imdb.com/title/tt0055630/
01-12-2005 00:01:45 info get url: http://akas.imdb.com/title/tt0055630/plotsummary
01-12-2005 00:01:47 info imdb number:tt0055630
01-12-2005 00:02:13 info loading skin file: dialogvideoinfo.xml
01-12-2005 00:02:13 info download: http://ia.imdb.com/media/imdb/01/i/44/26/10m.jpg->z:\temp.jpg
01-12-2005 00:02:13 info creating thumb from: z:\temp.jpg as: q:\custom\thumbs\imdb\imdbtt0055630.jpg
01-12-2005 00:02:14 warning kernel32.dll fake function disablethreadlibrarycalls called
01-12-2005 00:02:14 info msg:application transferred too many scanlines
01-12-2005 00:02:14 debug filecurl::close(d00e5e84)
01-12-2005 00:02:37 debug filecurl::close(d00e6c18)
01-12-2005 00:02:49 debug filecurl::close(d00e6370)
01-12-2005 00:02:49 info loading skin file: dialogvideoinfo.xml
01-12-2005 00:02:51 debug filecurl::close(d00e6c1c)
try using a folder.jpg file. that should work. (atleast it works in music.)
i havent had a chance to see why imdb lookups arent working, but its likely related to how they are cached. especially if your looking up items in the root of the multipath bookmark.
1) what are you looking up? a file, or a folder?
2) and what isnt getting the thumb? the folder, or the file?
3) where are these located? at the root of the multipath bookmark, or atleast one folder in?
no problems here as far as im aware! just done exactly the same... thumbs are fine in all views. mind you have deleted my db file recently so maybe thats the solution?
sorry it took a while ..
just done some more testing
it seems that if the media files (avi's) are in the root of the mb then thumbs dont work but if you create a sub directory that has the avi then the thumbs work correctly.
thanks, i figured that was the case. what kind of thumbs are they? "filename.tbn" type? folder.jpg doesnt work from the root of a book, and never did.
incognegro
2005-12-05, 23:57
i got another issue to report......in my music, i have three smb shares and they all have a folder.jpg but it only shows it for one folder, instead of all.
so have one share for rock as the first share and it shows the folder.jpg for those files but it also has a share for hip hop which is the second but refuses to show the folder.jpg for those files.
@incognegro
are you saying that no folder.jpgs show for folders found in the second and third paths in the bookmark?
please provide some more specific details which describe the paths involved, and a layout of the filesystem showing their location in the overall tree.
and is this specific to only to music?
ok, i just tested in both video and music. i get folder.jpg thumbs for folders which are in the root of the virtual path from all my real paths. i even added brand new ones to ensure they were not cached previously.
remember to re-enable "find remote thumbs".
same issue as senergy. i have a bunch of movies in the root of a multipath bookmark (the multipaths on my pc are d:\movies and e:\movies. i have a bunch of avi's inside both folders.)
imdb lookup works fine but no thumbnail is shown in "icon" view. if you query the movie, the movie information with thumbnail showup.
so, you have something like this:
<bookmark>
<name>movies</name>
<path>smb://server/d-movies-share/</path>
<path>smb://server/e-movies-share/</path>
</bookmark>
yes?
is no thumbnail shown, or is it just the default image? and if i understand you correctly, you do see the image on the movie info screen. correct?
i'll try to recreate this setup on the weekend. i'll move some files around to get a few movies into the root of my bookmark. right now, it only contains folders, and i see the folder.jpg images which are contained in them.
hi kraqh3d,
yes that's exactly how i have it setup. the default image just shows up and on the movie info screen the thumbnail is there. actually in these directories there are a couple of movies that don't have an imdb entry and therefore i have a "movie.tbn" file there and those thumbails show up. it seems that just the imdb thumbnails are not showing up.
thanks for implementing this feature, i've been looking forward to this for a long time.
kraqh3d,
i'm having a huge issue where no videos display in 'title' view.
some of my new movies (since multi-path was implimented) were showing and others were not.
i thought my myvideos31.db was corrupt (since this happens quite a bit... i wish the dbs were more stable!) so i renamed it and started over.
now i scan the video manually, choose the movie, and it dl's the info... but nothing shows in the 'title' view at all.
and the thumbs show fine in the 'files' view.
incognegro
2005-12-06, 14:46
ok, i just tested in both video and music. i get folder.jpg thumbs for folders which are in the root of the virtual path from all my real paths. i even added brand new ones to ensure they were not cached previously.
remember to re-enable "find remote thumbs".
hey thanx that worked........im sure i tried that vefore and it didnt work.......oh well it works now! :thumbsup:
good job! your work is well appreciated
now only to get this to be recognised in the httpapi client ( currently it only recognise the root)
update...
i know whats wrong with imdb thumbs... expect a fix in a day or two...
affini, if you dont mind, plz zip up your db and email it to me.... you dont have locked bookmarks, do you? this is likely one of two things... either path related, or related to the code that hides locked movies until the appropiate bookmark is unlocked. the matching code gets a little confused when there's two bookmarks that are identical. first one wins. and when there's two bookmarks which overlap, the one with the longest matching path wins.
hmm... i didnt realize the httpapi didnt recognize these paths. it should unless its circumventing xbmc's cvirtualdirectory class which abstracts *all* filesystem types. i bet httpapi doesnt understand the new virtual stack:// filesystem as well. i'll contact nad about this.
affini, if you dont mind, plz zip up your db and email it to me.... you dont have locked bookmarks, do you? *this is likely one of two things... either path related, or related to the code that hides locked movies until the appropiate bookmark is unlocked. * the matching code gets a little confused when there's two bookmarks that are identical. *first one wins. *and when there's two bookmarks which overlap, the one with the longest matching path wins.
hmm... i didnt realize the httpapi didnt recognize these paths. *it should unless its circumventing xbmc's cvirtualdirectory class which abstracts *all* filesystem types. *i bet httpapi doesnt understand the new virtual stack:// filesystem as well. *i'll contact nad about this.
i don't lock any bookmarks.
i'll email both the new db and the one that "partially" worked.
ok... im pretty sure i fixed imdb thumbs for items in the root of a multipath videos bookmark (hopefully without breaking anything else). give it a try.
how long does the anon cvs take to propergate your changes?
because i just created a new build and the imdb thumbs still dont work.
dont know exactly. but i can confirm that i got imdb thumbs showing up for files in the root of my multipath bookmark. post your debug log, i can tell if you have the code or not from it.
i put a new build on and the thumbs do in deed showup, a pleasant surprise was all the thumbs/info that i imdb'd for a single bookmark also show up in the multiple bookmark.
thank you!
good. so, we'll consider the thumb issue closed then. and yes, that's on purpose. i made sure that if the paths you've defined in a multipath bookmark overlap with an older single path bookmark, the thumbs will show up.
just so you know, there's a downside to overlapping bookmarks... the video database has code which will "hide" items from locked bookmarks until the bookmarks are unlocked. i think this was requested by some porno addict :)
since the database only knows paths, xbmc has to match the path to a bookmark. the first 100% matching bookmark always wins and returns immediately. (by 100%, i mean the path in the database is exactly a bookmark path, case insensitve.) if there isnt an exact match, the longest matching bookmark path wins. but, due to the first case, the order matters. so if you have a multipath bookmark which is not locked, and you had an overlapping exact bookmark above it that was locked, those items wont be seen.
also, this systems provides a little extra security. instead of locking a bookmark, you can completely remove it from the config to hide items in the database. that's the best way to hide your porn :)
** edit **
oh yeah... this weekend, i noticed that jmarshalls optimized sorting routines fix the sporadic issues i had with music. any other issues?
yup imdb thumbs work perfect now.
thanks a lot!
i know this is the feature many of you have been waiting for. over the last two weeks, i silently added support for this to music as test. once its all sorted out, it can potentially be ported into video and pictures. i've been testing it myself for the time being and fixed a few issues i had introduced. so far, i can say it works as well as any other bookmark type. i even scanned my music thru one of these bookmarks. now, i need a larger community to test it.
it only accepts hard drive, samba, and xbms type paths. any others will be stripped while the configuration is read. it's built on top of the existing directory and file reading classes so all the wierd problems some people have with samba will be present here as well. i recommend using guest access or putting the workgroup and user details in the samba paths. it'll work otherwise, but it may be confusing if you're asked to provide user details for more than one samba path.
since comma is a valid character in samba and xbms, we cannot use comma seperated paths as the path definition. instead, i've added support for multiple paths in the true xml way:
<bookmark>
<name>music</name>
<path>e:\music</path>
<path>f:\music</path>
<path>smb://someserver/music</path>
<path>xbms://someotherserver:1400/music</path>
</bookmark>
you may have noticed in the changelog that this format is also now supported my programs bookmarks :)
what it does... it retrieves all the items from each of the defined paths and puts them into a single directory listing. it is a little slower because more than one path needs to be retrieved. and be careful with how many paths you use, and more importanty, how many items in each path. the xbox has limited memory, and will likely have problems if all the paths combined return 20,000 items.
what it does not do... it does not consolidate items that are named the identically into a single item. you can and will have more than one item with the same exact name.
known bugs... sorting doesnt work correctly. when sorting by name (the label of the items), sometimes items which are named identically are not next to each other.
hi,
i just wonder if that would work for more than 1 smb share on the same server - my situation :
i use a linksys fg250v2 nas storage device and the shares are bind a single directory on either one of the hdds ....
therefore i'd need to be able to do a thing like :
---------------------------
<bookmark>
<name>smb network share</name>
<path>smb://uuu:ppp@192.168.0.99/moviez 1</path>
<path>smb://uuu:ppp@192.168.0.99/moviez 2</path>
</bookmark>
<bookmark>
<name>workgroup (smb) network</name>
<path>smb://uuu:ppp@192.168.0.99/moviez 1</path>
<path>smb://uuu:ppp@192.168.0.99/moviez 2</path>
</bookmark>
-----------------------------
same required for pictures, muzak and files/games
any idea of how to solve that ??
and i am using an older version of the xbmc - from which version multi pathed bookmarks will work - especially the samba ones ;-)
cheers - ahab666
i just wonder if that would work for more than 1 smb share on the same server
wow, no one likes to experiment anymore, eh? yes, of course, you can do that!
in one of my shares, i have four smb:// paths defined. not only do i have two shares point on the same computer due to two hard drives, i also have two other samba shares on two other computers being collapsed together into a single listing.
if you have two share points (one for each hard drive), just put them both in the same bookmark, just like in your examples. (though i dont know why you would list them in two different bookmarks like that. you dont need to do that.)
basically, you can mix and match multiple smb://, xbms://, and hard drive paths. but, remember that xbmc has a finite amount of memory. if the combined number of items (folders and files) in the root of all these paths is very high (over 10,000), xbmc will likely crash.
hi kraqh3d,
first of all to say thanks for adding this its awesome, something i (and many others) have been waiting a long time for, really appreciate your efforts.
just wondering if you have any plans to make it (optionally??) consolidate identically named folders into one. imo this would make this absolutely perfect as it would mean files could be invisibly spread across shares.
thanks again,
coined
at this time, i have no plans to add folder-level consolidation.
MidKnight
2006-02-05, 01:49
hi kraqh3d,
first of all to say thanks for adding this its awesome, something i (and many others) have been waiting a long time for, really appreciate your efforts.
just wondering if you have any plans to make it (optionally??) consolidate identically named folders into one. imo this would make this absolutely perfect as it would mean files could be invisibly spread across shares.
thanks again,
coined
that would be awesome