View Full Version : Watched/unwatched flag
MercuryInc
2005-09-08, 18:17
just letting everyone know that i'm working on 2 new my video pages. one shows movies that you mark as having been watched, the other shows movies that you havn't marked as watched. (kind of like how my videos for mce 2005 works, but no external interface)
i'd like to hear any ideas on the matter, and i'd also like to hear if you like the idea of the feature.
Gamester17
2005-09-08, 18:55
fyi; previous ideas/suggestions/requests (link) (http://www.xboxmediaplayer.de/cgi-bin/forums/ikonboard.pl?act=st;f=4;t=1648)
although i welcome any attempt to add stuff to xbmc, i do not think that approach is the best. one problem is that it would mean no 'fluent' integration with a video library (if it is ever created).
and having an own view seems a bit overkill to me.
however, i've been thinking about adding support for overlaying on icons / thumbs. although i plan to use it for something different, perhaps it could be used for this as well. add configurability and you can overlay an icon in e.g. the left corner for you and in the right corner for your wife or whatever..
thoughts?
MercuryInc
2005-09-08, 19:26
i'm open to your suggestion, but let me be more specific and make sure that your statement still stands.
i'm not modifying anything regarding the video library. all i've done is coppied the myvideotitle code and added a view by item called watched and unwatched. then i modified the database to have a table that lists watched movies, so when the video gui library selects videos do display in the list view it only lists watched movies, or unwatched movies.
(so basicaly its just a gui addition)
do you still feel its a bad addition?
i welcome the addition. it can be moved into the video library if it gets added (sort of like top100 in my music).
i might do the overlay thing as well, there is no conflict between the two methods as such.
however, you'll have to convince more ppl than just me before it gets added :)
if i were you, i wouldnt add more windows. *i suggest you fold this directly in title view. *you can add a button like "view as" which cycles between all, watched, and unwatched. *then "getdirectory()" would check that status, and call the correct query from the database.
to go even further, the current query can easily be modified to accept this state as an extra argument, (defaulting to "all" so as not to break anything.) *all you're really doing is adding a "and movie.watched = true" or "and movie.watched = false" to the end of the standard query.
until overlays work, you can have "all" view just add an asterix to the end of a movie name for those which have already been watched. *(i'd suggest making that a configurable option tho.)
los93sol
2005-09-08, 21:31
just wondering and not sure if this should be in the feature suggestions or not, but what about tying an image to different profiles and you can use that as a "tag" to determine who watched the video. my suggestion would be to set it up so that at least 85% of the video has to be played for it to be considered watched. that way you would eliminate missing a video you have watched but stopped before the credits played through since most people don't watch them anyway and also eliminate marking files as watched that have only been started briefly to check the quality or that you didn't have time to finish watching.
regards,
los93sol
los93sol,
that would kinda work, but it seems silly because profiles are not really users. *while you may be using as such, thats not the intention.
not only that, it would also only mark the "last" profile to have watched the movie. (tho this can be worked around using a new table that acts has a many-to-many cross-ref table.)
los93sol
2005-09-08, 23:05
yeah...i guess you are right about that, i've been using it so long for different users that i forgot it's actual usage. :p i guess my idea would in fact then be a feature request for a user logon and in turn tracking it that way .:plants a seed:. lol in my opinion for this to be a useful feature it should be detailed and automated so the user wouldn't have to tag files individually. anyways, sorry for my brain lapse, thought i was onto something.
regards,
los93sol
MercuryInc
2005-09-08, 23:17
all great and wonderful feedback. i had thought about using profiles to organize who had watched what, but i'll probably do that in a revision if it catches on.
as for the database here is my plan
--select watched
select * from movie where idmovie in(select idmovie from watched)
--mark as watched
insert into watched (idmovie) values(x)
--mark as unwatched
delete from watched where idmovie = x
--select not watched
select * from movie where idmovie not in(select idmovie from watched)
--upgrade
create table watched (idmovie integer)
which could easily be modified to account on a profile basis.
i also like the idea of just adding a control to the titles that says something like show ->all,watched,unwatched. i think i'll go that direction. adding a new window was a pain.
MercuryInc
2005-09-08, 23:24
sorry for the double post, but i've been debating with myself :nuts: about people wanting automatic "watch detection" and people thinking its to sensative. so my new line of thought on that matter is to make a setting for "autowatch" and modify the onclick to mark a movie as watched if its played and the autowatch feature is set, and if its not the user will have to "right click" each title and mark it as watched or unwatched (using the same menu that removes it from the imdb database)
vita10gy
2005-09-09, 06:54
instead of just keeping a list of watched video files could you add when you watched them and then potentially let the user sort by last watched time. rather than just a flag keep the time, no last watched date obviously means it hasnt been watched, so this accomplishes both tasks, killing two birds with one stone, leaving the door open for other features. (watching history, stats of many kinds, ect)
MercuryInc
2005-09-09, 08:31
the only problem there is then there is clutter added to the ui in the form of watched lists. also, some people arn't considering the movie watched just because it was played.
anyways, here is the proof of concept should make it more clear what i'm trying to do. it keeps the code base changes pretty small (only guiwindowvideobase.cpp, videodatabase.cpp and the language files are modified) and one table (create table watched (idmovie integer)) is added to the database keepin that small too.
quick thanks to kraqh3d for sugesting not using another window. that made the code cleaner and easier to code.
so step one (a list of the movies i put in the db notice 36 items):http://www.mercuryinc.net/xbox/movietracker/screenshot000.jpg
step two toggle to watched list (count 1)
http://www.mercuryinc.net/xbox/movietracker/screenshot002.jpg
step three toggle to unwatched list (count 35)
http://www.mercuryinc.net/xbox/movietracker/screenshot003.jpg
step four mark airheads as watched
http://www.mercuryinc.net/xbox/movietracker/screenshot004.jpg
step five airheads is gone from the watch list (count 34)
http://www.mercuryinc.net/xbox/movietracker/screenshot005.jpg
step six, back to watched and airheads is there (count 2)
http://www.mercuryinc.net/xbox/movietracker/screenshot006.jpg
step seven, wife decided she hadn't finished airheads so mark it back as unwatched for now
http://www.mercuryinc.net/xbox/movietracker/screenshot007.jpg
step eight watched view now lacks airheads (count 1)
http://www.mercuryinc.net/xbox/movietracker/screenshot008.jpg
i'll be submitting this as a patch once i hear back from you guys.
hi,
looks cool :)
however, i have to ask. do you really think it's necessary to have a 'watched' view. imho it's only interesting to have a list of unwatched movies, since that's really the point of this, no? to keep track of what you haven't watched. i'm of course open for arguments..
i woud probably add a "watched" field to the existing movie table instead of creating a complete new table with watched movies. the "watched" field can than be a bool or a timestamp or whatever...
cheers,
luna
MercuryInc
2005-09-09, 18:01
another good point spiff.
i decided to add the watched view so i had an easy way to remove it from the watched list if a mistake was made or someone wants to mark it back as unwatched. (rather than having to use the title view and onpopup determine if the movie has been watched or not, onpopup i just determine what view i'm in and add a menu item for mark unwatched or mark watched) also, you don't have to dig through your entire movie list to find the one mistake you made. check the logic on that and see if you'd still just have a title view and unwatched view.
now, to luna, at first i tried adding a bool field to the movie table, but when i did all the other queries to the database failed for some reason. (anyone got a clue about why that would happen?) and i didnt' want to modify all the queries for genre, year, actor...
also, i just noticed that regardless of the view it says myvideoo -title, so i'll fix that up before i submit the patch.
one quick question since i'm new to the boards. what is the best way to let the people, in the suggestions/request link that gamester17 posted, know about this and to try and stirr up more exitement about this patch? (i don't want to violate any rules like linking to posts or copying posts or anything)
nice work so far...
im not sure why you were unable to add a field to the existing movie database. but, if you were to add a "lastwatched" field, and a "lastwatched" field to cimdbmovie, you could sort by last watched.
this would be really cool when used along with the autowatch option.
los93sol
2005-09-09, 21:33
looks great so far! best way to let people know is to go back to that thread and just leave a message that it's been submitted as a patch, add a pic or two and a link to the patch. i would be careful about linking to the dev boards here because you might end up with this thread being cluttered by useless responses, but i don't believe there are any rules against it.
i have to agree with luna about tying it in with the existing database, but i bet this initial patch will get a lot of dev attention since the current views for videos are good, but not quite on par with the music views. this would be a great enhancement. :)
regards,
los93sol
MercuryInc
2005-09-09, 22:01
i ran into some problems using the existing tables but kraqh3d is lending some assistance there, so probably tonight when i get home i'll update it.
another noob question i have is:
how exactly do i submit a "patch"? do i submit the changed files and everyone that wants it has to recompile them, or is there something i'm missing?
valid point indeed.
just submit the modified files at our sourceforge page.
los93sol
2005-09-10, 01:59
a quick note about submitting the patch, little notes are good, it is nice to know what date/time of cvs the modified files came from since as the files are changed throughout revisions they can have conflicts and not compile correctly. this is not an issue for developers who know the code and know what they are doing but for end users who do their own compiles to test it, most of them will not be able to unless they have the proper cvs date/time and just replace the original files with your modified version. just a suggestion. :)
regards,
los93sol
MercuryInc
2005-09-14, 00:48
ok guys, i stabalized the patch and got it to work the way i imagined. if anyone gives it a shot and likes/dislikes it let me know.
patch download (https://sourceforge.net/tracker/index.php?func=detail&aid=1290469&group_id=87054&atid=581840)
this patch was developed for the 2005-09-12 cvs, but works for quite a few of the previous versions. i
don't know of anyone doing work on the changed files, so i imagine it should work for quite some time.
this patch add the fallowing features:
1:list video's by watched
2:list video's by unwatched
3:mark video as unwatched in watched view
4:mark video as watched in unwatched view
5:edit video titles in title, watched, and unwatched views
notes:
1:the watched/unwatched views will not show up unless title/watched/unwatched is selected as the active
view. i.e. if you open my videos and it defaults to show files, then move to titles and watched and
unwatched will appear in the show list.
to add use this patch:
1:dump the xbmc folder over the cvs xbmc folder.
2:rebuild
3:dump the skin and language folder over your skin and language folder.
4:enjoy
changes from base:
1:skin file labels the description label so it can change from my videos - title to my videos - watched
and my videos - unwatched.
2:added functions to support above functionality
3:modified guiwindowvideotitle.cpp to call getvideos with watched/unwatched flag set
i can't wait to see this being in the cvs great work, i will use this a lot.
now that is the thing my wife will love, she has 20 shows of lost on the disk and she always forgets what she had watched :-(
how can i as a non developer (too dumb to compile) use this feature? it is not in the 27-9 build :-(
yours
jerry
i welcome the addition. it can be moved into the video library if it gets added (sort of like top100 in my music).
i might do the overlay thing as well, there is no conflict between the two methods as such.
however, you'll have to convince more ppl than just me before it gets added :)
i would like such feature, i was the one that proposed flags or something, so my wife has different flag and i have different. your approach i would like such feature, i was the one that proposed flags or something, so my wife has different flag and i have different. your approach seems excellent to me!seems excellent to me!
MercuryInc
2005-10-08, 02:25
as for getting the feature, since its a patch you must (or someone you know must) compile the application with the patches applied. (no other way until its in the public cvs)
i've been working on getting it coded to a standard they won't mind putting in the cvs and should have it completed this weekend. (then they'll review cretique and i'll be back to the drawing board)
i am open to the idea of a watched list by user, and wouldn't mind puting it in the patches.
give me some sugestions on how you plan on using it, (since they probly won't like me using profiels to distinguish)
as for getting the feature, since its a patch you must (or someone you know must) compile the application with the patches applied. (no other way until its in the public cvs)
i've been working on getting it coded to a standard they won't mind putting in the cvs and should have it completed this weekend. (then they'll review cretique and i'll be back to the drawing board)
i am open to the idea of a watched list by user, and wouldn't mind puting it in the patches.
give me some sugestions on how you plan on using it, (since they probly won't like me using profiels to distinguish)
personally i would like to flag the file's using a filter to cycle trough them:
person a (seen --> not seen --> all
person b (seen --> not seen --> all
well and if we are already flagging files, rating them would also be nice, especially if we could rate the movies directly into imdb accounts (but that’s something else).
i’m looking forward to find it in the cvs to play around with.
no profiles that's bad…. profiles could also be nice to setup a fresh xbmc quicker, now i have to set the all options once in a while again. even i can save profiles in xbmc i would like to be able to in/export them…..
i would use a different colour flags, like blue for me and red for wife etc. that would be the ultimate system imho, because as it is now if one in the family watches a series ahead of the other the marking is not that powerfull (only one can see where he/she is)...
please don't ban me here, i see now this forum is only for developers anyway and i shouldn't even post here :-( as binaries are not found here and from what i read they are illegal? so it is not possible (allowed) for anyone to send me the modified binaries without breaking the law (which of course i don't want :-)? i would so much like to test this feature as implemented and i then make some more suggestions.
another point, different, is about making bookmarks in files (the place where you stopped). they are stored in a global file in each xbox. well, i and i guess an not alone, have 2 xboxes, so if i watch a movie on one and create bookmark i can not have this bookmark on another one. as i have external server for moview all i would like is to be alble to store this bookmarks on this server, so i can have them "globally". is that even theoretically possible?
and again, thank you for making a patch for watched/unwatched? i made a few posts but nobody seems to care about it and i thought: am i the only one that have several series on the disk and don't remember what i looked last (and doesn't delete it because of other family members who may watch it also)...
yours
jerry
MercuryInc
2005-10-08, 20:17
i'm probably not going to be able to add persanolized watched/unwatched this weekend, but it something i also want so i'll keep it in mind.
i like your global bookmark idea, however i see two problems. 1 its outside the scope of this particular project (but it would also be cool to personolize the bookmarks). and 2 if you give your xbox permission to write and change files on your server its possible that the xbox could also delete them. i also keep my video's on the network, and my wife usualy hits the wrong buttons :) i always come up with video's missing so i disabled the video deleting in the title screen. (hopefully you can relate:))
i'm hopinig that if they like they way i've got the patch this weekend they'll put it in the cvs soon
i like the watched/unwatched features... very useful.
one suggestion...
what about integrating a marker/highlight into the standard views that would enable you to know if the video was no watched?
i.e. in the normal title view, if a video had not been watched yet the text would have a marker to let you know...
small eye img
circle with slash img
color bar underlining text (change color to use profiles).
i'm probably not going to be able to add persanolized watched/unwatched this weekend, but it something i also want so i'll keep it in mind.
i like your global bookmark idea, however i see two problems. 1 its outside the scope of this particular project (but it would also be cool to personolize the bookmarks). *and 2 if you give your xbox permission to write and change files on your server its possible that the xbox could also delete them. *i also keep my video's on the network, and my wife usualy hits the wrong buttons :) i always come up with video's missing so i disabled the video deleting in the title screen. (hopefully you can relate:))
i'm hopinig that if they like they way i've got the patch this weekend they'll put it in the cvs soon
about global bookmarks: i know it is unrelated to this product, it is just simillar in concept - watched/unwatched is on a file scope and the bookmark in inside file scope. i can certanly relate to point 2 :-)))
is there any legal way i could get the binaries of the patched files, so i can give my wife a present (and to myself because now she call me every time and asks: which lost have i looked last time? :-(
another idea: would it be possible for xbmc to remember the position of the cursor in a folder? that way i could also see what i watched in series? but your method is already better than this, although i haven't tested it...
i looked for the compiler... way to expensive to compile the fix. i would have to buy 2 compilers :-(
[quote=mercuryinc,oct. 08 2005,18:17]is there any legal way i could get the binaries of the patched files, so i can give my wife a present (and to myself because now she call me every time and asks: which lost have i looked last time? :-(
well you could compile yourself with the very easy solution from http://johnypcguru.home.mchsi.com/
yes you need to get the xbox sdk en visual studio yourself,but it's possible even for noob's. you will have to wait or diy instead of complaining :) !
tip: use a vmware pc, i have it all set up in a virtual pc, i only use it to compile xbmc, fast and it keeps my normal windows clean.
good luck
mercuryinc: it didn't make it in new build?
MercuryInc
2005-10-10, 18:49
i finished the new patch sunday morning around 4am, and tested it all day yesterday. i'll be submitting it when i get home today. hopefully it meets with the dev's expectations.
keep checking the board, i'll keep you posted as to when the patch is available, and when/if it gets into the cvs.
MercuryInc
2005-10-11, 05:36
alright then, as promised, the patch has been uploaded (if you havn't figured out how to build yet jerry, then hopefully this revision will make it to the cvs).
here is the info, i'll be emailing kraqh3d (so check your mail if your reading this) to see what he thinks.
this patch was built using the 2005-10-08 cvs, but will probably be forward compatable until another database change is made, and backword compatable (most likely) clear back to the 2005-09-14 release. (but just stick with 2005-10-08, its safer)
alright, i gave it a second shot, this should take care of some of the stuff kraqh3d wanted me to take care of. and its a bit more user friendly. (the sql statments have also been revised to make it a little faster)
changes:
there is one button on each of the video pages (accept playlist and files) that shows "all videos", "watched" or "unwatched". the setting is global, i.e. if you are in title view with unwatched set and move to actor view, only actors in unwatched movies will be listed, if you then switch actor view to be watched, then the title view will show watched video's, and so on and so forth.
mercuryinc,
what do you think about the color coding (or mini-icon) idea? i'd prefer have a method like that so i did not need to change the view just to know what was already watched.
MercuryInc
2005-10-11, 08:21
i'm not entirely apposed to the idea, but i put this together so i didn't have to fish through what i have already seen, to find what i havn't. i suppose i could look into when the all videos is selected it color codes a line around the icon or something like that (or an overlay). now that we have time to think amongst ourselves we think its not such a bad idea. i like it, i'll see what i can come up with. (next revision of course) :)
cool... i was thinking something very simple like an underline for the text... you could have different colors for if/when you impliment it for multiple people. this way you could be able to show if multiple people have watched it all at once.
los93sol
2005-10-11, 10:06
there's an interesting thought affini. i think that would be a nice compliment to what he's got here. it would be nice to just have new unplayed media display a nice contrasting color or something, and have this throughout xbmc so applied to all sections. yep, that would be a cool feature to compliment this project. i'd really like to see this pulled into the library view when it finally gets created for videos, but until then this should be good. :)
regards,
los93sol
mercuryinc,
what do you think about the color coding (or mini-icon) idea? i'd prefer have a method like that so i did not need to change the view just to know what was already watched.
i think this implementation would be best! not needed to change view and multiple family members friendly.
alright then, as promised, the patch has been uploaded (if you havn't figured out how to build yet jerry, then hopefully this revision will make it to the cvs).
here is the info, i'll be emailing kraqh3d (so check your mail if your reading this) to see what he thinks.
this patch was built using the 2005-10-08 cvs, but will probably be forward compatable until another database change is made, and backword compatable (most likely) clear back to the 2005-09-14 release. (but just stick with 2005-10-08, its safer)
alright, i gave it a second shot, this should take care of some of the stuff kraqh3d wanted me to take care of. and its a bit more user friendly. (the sql statments have also been revised to make it a little faster)
changes:
there is one button on each of the video pages (accept playlist and files) that shows "all videos", "watched" or "unwatched". *the setting is global, i.e. if you are in title view with unwatched set and move to actor view, only actors in unwatched movies will be listed, if you then switch actor view to be watched, then the title view will show watched video's, and so on and so forth.
i have figured out how to do it, but the cost for developent tools are too big :-( just for this one compilation.
MercuryInc
2005-10-11, 17:25
just an fyi jerry2, you can usualy find the development tools in some of the same places you find the xbmc build. thats probably all the direction i can give you on this board.
los93sol: can you give me a handle on what you mean by "library view"? if you describe it, it might be something i can handle.
what i've actualy been thinking about doing is adding the ability to create "catagories". so basicaly the all/watched/unwatched would always be there, but if you were to add, say a "wife" section and a "child" section, then those would be on the same button and when the wife goes to her section she'll see movies she's put in there (same effect as multiple users, but i don't have to manage user login). color coding or overlay at that point would be a problem since the info for multiple users would come from the db and the marker saying weather a movie is watched or not would have to be in cimdbmovie. so unless you guys have some sugestions the all videos setting will probably just show if it is marked as watched or not.
i kind of like the idea of a small overlay that looks like a checkbox for watched movies and an uncheckedbox for unwatched. (ideas? comments? let me know)
just an fyi jerry2, you can usualy find the development tools in some of the same places you find the xbmc build. thats probably all the direction i can give you on this board.
los93sol: can you give me a handle on what you mean by "library view"? *if you describe it, it might be something i can handle.
what i've actualy been thinking about doing is adding the ability to create "catagories". *so basicaly the all/watched/unwatched would always be there, but if you were to add, say a "wife" section and a "child" section, then those would be on the same button and when the wife goes to her section she'll see movies she's put in there (same effect as multiple users, but i don't have to manage user login). *color coding or overlay at that point would be a problem since the info for multiple users would come from the db and the marker saying weather a movie is watched or not would have to be in cimdbmovie. so unless you guys have some sugestions the all videos setting will probably just show if it is marked as watched or not.
i kind of like the idea of a small overlay that looks like a checkbox for watched movies and an uncheckedbox for unwatched. *(ideas? comments? let me know)
yes overlay with checkbox would be great, also the categories list. so one can hide dirty movies from his wife :thumbsup: haha
@mercuryinc, (and everyone else),
i just integrated your patch into cvs. very nice.
i made a few minor changes to it, to keep it inline with some future plans. i actually added bwatched to cimdbmovie. this can be useful later on. (with some changes to list/thumb controls we can be update this later so the view can change without having to requery, by only changing which items are to be visible.)
i also made the all/watched/unwatched status a per-window setting. so title can be left in unwatched, and genres could be left in all.
and since overlays dont exist as yet, i added a little visual identifier when in "all videos" view -- the title will have [w] on the end to mark its been watched. if its too distracting it can be removed.
** edit ** i also left in your "edit title" context menu option. :)
MercuryInc
2005-10-15, 02:28
awsome, this is way cool. i'm downloading the cvs now, and hope to be able to show the overlays within the next couple of day.
(thanks for leaving the edit title in, i wasn't trying to sneak it in or anything, it just happend to be in the same file:))
i prefered having the all/watched/unwatched status a global setting, but i'll make a setting so users can select that and put it in the my video section later (not a major concern) (if anyone else has an opinion on this let us know)
thanks man. i'm way exited about this
this is nice... it may actually be able to replace the ram (recently added media) screen which never worked very well.
it would be cool to be able to have a new screen that we could link from the main screen to show a list (or icons) of unwatched movies.
this way no need to navigate an entire library or switch view for guests... just start xbmc and choose "new movies" (or whatever you name it on your screen).
lots of potential... could even start recording the last date watched and number of times watched... then you could do the a "most watched" and a "least watched" screen.
btw... kraqh3d,
any chance you know of if we will be getting overlays? it would definitely be nice in cases like this where i'd like to have a color overlay or a small image next to the text instead of needing to put a [w] (which is a good alternative).
guys... seriously, nice work!
MercuryInc
2005-10-15, 02:48
definently on the overlays, i'm doing a small checkbox, but a colored overlay would be no problem. i have it displaying the overlay, but i'm having a little bit of trouble putting the correct overlay on the correct movie. (give me some time:)
thanks for you comments.
@affini
it would be cool to be able to have a new screen that we could link from the main screen to show a list (or icons) of unwatched movies.
i was thinking of that too. it would be trivial to allow the db windows to take an argument of "all", "watched", or "unwatched" so that it can open with a specific the show mode. your "unwatched movies" window could be as easy as using xbmc.activatewindow(myvideotitles, unwatched) in a button or the submenu.
lots of potential... could even start recording the last date watched and number of times watched... then you could do the a "most watched" and a "least watched" screen.
yes, but that has nothing to do with the current watched status. if you read thru the thread, it was decided that the watched status be made manual. those options would require it be automated which leads into the question: how far into a title is it actually considered "watched"?
btw... kraqh3d,
any chance you know of if we will be getting overlays? it would definitely be nice in cases like this where i'd like to have a color overlay or a small image next to the text instead of needing to put a [w] (which is a good alternative).
no, thats why i added that alternative for now.
@mercury
i prefered having the all/watched/unwatched status a global setting, but i'll make a setting so users can select that and put it in the my video section later (not a major concern) (if anyone else has an opinion on this let us know)
a setting for this is a good idea. i want them seperate for the exact example i described earlier. if i'm going into genre's, its to find a movie to suit a particular mood. and i typical would want to see all the movies which fit that genre.
each window has an "if" in gui_msg_clicked for the show mode button. just need to update all four settings instead of the local one when that global option is enabled.
and since overlays dont exist as yet, i added a little visual identifier when in "all videos" view -- the title will have [w] on the end to mark its been watched. *if its too distracting it can be removed.
no please don't remove it! so in fact i will see the w on the movies that are watched when the settings are on show all? that is almost a flag! no, it is a flag... but a flag for only one person, but anyway, i prefer marking in show all list than having a special list for watched.
anyway, now that it is in cvs, can i hope i can see it in action soon?
HarshReality
2005-10-15, 21:55
if its too annoying (i dont care actually) with the [w] at the end of the title, how difficult would it be to place it in the movie info screen say scrolling across the bottom.
"last accessed: date" or "this media has not yet been accessed"
MercuryInc
2005-10-15, 22:02
any cvs build after mid afternoon yesteraday should have it.
just to be safe, look for one built today.
i'm about 90% done with the overlay idea you guys gave me, so we can remove the [w] after its done, but i have some questions for you guys.
if i were to integrate multiple users into this it wouldn't support multiple overlays. since they will just show watched or not (checkbox checked for watched checkbox open for not watched).
my thoughts on the multi users would be to allow adding of "categories" which could be names or things like "tv", whatever. you would still mark things as watched or unwatched, but the all video screen would allow you to add videos to different categories. (it would function alot like the idea behind the genre section, but be user defined)
get me some thoughts and ideas so i can get you what you want. (specificaly jerry:) but all sugestions are welcome)
HarshReality
2005-10-16, 00:08
you mena profile sensative?
MercuryInc
2005-10-16, 01:19
negative on the profiles. jerry wants to make it user specific, but xbmc doesn't have users, so the next best thing would be to add categories and name the categorys "user 1" and "user 2" and so on. so basicaly the watched unwatched button would function something like this: "all videos"->"unwatched"->"watched"->"user 1" ->"user 2"
(show all videos, show unwatched videos, show watched videos, show movies marked with user 1, show all movies marked with user 2)
maybe i'll do a mock up.
i'm mostly asking for descriptions of how you would like to see it (since i'm not sure the best way to do it myself)
los93sol
2005-10-16, 03:34
i agree that basing it on users would be the absolute best way to do this, but perhaps this project has lead to another project at this point. actually create users for xbmc, in my opinion the project has evolved far enough that it would be a nice feature at this point and would properly add users to the watched/unwatched content feature as well. just something else to consider.
regards,
los93sol
HarshReality
2005-10-16, 05:17
i tried a fresh build today to see what you had cooking but to no avail the submenus for videos were screwed... everything offered me a delete option. clicked settings from within video and get an are you sure you wish to delete dialog. scared the hell right out of me.
i will point out a point jm and g are very fond of bringing up about how this is not an operating system, bringing in user settings is really pushing twords os, next thing you'll be having user set skins and password logins.......
MercuryInc
2005-10-16, 06:49
all i can sugest there, is to do a clean build with the default skin in a different folder (maybe e:\apps\xbmctest is where i usualy test it out). also, backup your tdata and udata folders and delete them. sometimes crap get stuck in them (but not usulay) when you are upgrading to a new version in the cvs.
one other thing to check, i know it may sound funny, but make sure you are in the title, actor, genre, or years view. it doesn't work in the file view. (i don't mean to talk down to anyone, but some people don't use the other views, they are happy with the way the file view works and so they don't know to use them)
hope that helps. if not, let me know what else you've tried and maybe provide some screen shots.
negative on the profiles. *jerry wants to make it user specific, but xbmc doesn't have users, so the next best thing would be to add categories and name the categorys "user 1" and "user 2" and so on. *so basicaly the watched unwatched button would function something like this: "all videos"->"unwatched"->"watched"->"user 1" ->"user 2"
(show all videos, show unwatched videos, show watched videos, show movies marked with user 1, show all movies marked with user 2)
maybe i'll do a mock up.
i'm mostly asking for descriptions of how you would like to see it (since i'm not sure the best way to do it myself)
hm, firstly i am sorry there are no users in xbmc. that would make a great use, make user for kids so they have only cartoons, for wife with soap operas and for us, you know what :thumbsup: but i guess making users digs to deep into the xbmc concept. so as it is now, i am ok with the idea of the user 1, user 2 as a category. but why is there in the menu still the watched and unwatched? aren't the user 1 and user 2 to show only unwatched movies? whose movies will unwatched menu option show?
is there any way to make flags, as you will make graphics overlay now, so every file would be able to carry 3 flags. one for me, one for wife and one for kid. each flag would have a different colour, like blue, green and red. so before any file there could be any or all of the 3 flags set. you would set them by using the menu and have set blue, set red and set green. family member would have to know what colour he/she has :-) that was you would not need to play around with the options but would have flags by the files as [w] is now. the obvious dissadvantige i see is there could be a limited amount of flags (like 3) and your use with categories would have unlimited amounts of them. but setting with the categorries and then going back if i want all of the files again i am not very comfortable with. because the dissadvantage of flags is 3 users max (if possible?) but then again how many family members do we have? 10?
just my idea, you don't have to take it. i hope i was clear enough, as i am not native english speaker, i am from slovenia. my idea is like windows file system with flags, you also have archive bit and some others and you see it in explorer.
but if that is not wise or possible, your idea of users if good and certanly more than i have now :-) but user 1 would mean watched for user 1? why have the "watched option" then, for whom? if watched files are in different categories :-)
thanx for making my dream come true. well ok, it is not a life dream but yes, i am hardly waiting for the new cvs with it...
mecuryinc,
great work btw! (i must admit i haven't gotten around to actually testing yet though :))
with overlay, i assume you mean an overlay on the thumbs. how did you implement this, ie is it general (put into cguithumb or whatever the class is called) or is it just special code that would only work for what you're using it for?
the reason i'm asking, is that i've some plans of my own that include overlays, but i never got around to actually adding it.. perhaps i can be lazy and leech off somebody elses code once again :)
@mercury,
fyi... i'm in the midst of making cimdbmovie a member of cfileitem, like how for music items, m_musicinfotag is a member. this will give the video db windows access to the db information all the time, and not just during the cfileitem creation.
i to can confirm context menu madness... settings = delete & delete = i think its rename.
resorting back to 14-10-05 cvs as its a nightmare at the moment. i tried to view cvs 'list' but does not look like all files patched were logged on forge so did not know where to look for watched/unwatched patched .cpp files relating to the context menu issue.
still a nice feature though :)
MercuryInc
2005-10-16, 20:08
i am actualy implementing the overlays in the guilistcontrol and guithumbnailpanel (in the render function)
since that is where the icons get created. it is a bit of a pain though since those don't have access to the cfileitem class. (the data seams to be passed through a vector, and i can't seem to figure it out) please look at the topic vector madness in the developer section for more info (help if you can) but this means that you would be able to use the overlay anywhere a listconrol or thumbpanel is used. (the new member variable is m_bchecked, so its generic) again it shows an empty or checked box based on that flag, so any file item can have one. i am surrounding it with an if(this.getparentid = a video window) so it will only work for the video section until someone else extends the other windows.
i'm sorry to hear that the menus are getting messed up. kraqh3d made a couple of changes to my patch, but the 2005-10-15 build seemed to work ok. kraqh3d any ideas on the menu's?
i'll take a look at the context menu. maybe something got munged.
**edit ** something definately got messed up. i think i accidently committed something that wasnt ready yet. i need to undo all my changed and full recompile to figure out whats wrong.
MercuryInc
2005-10-16, 23:36
before you re-release, i have the overlays working. so i'll submit that to the same patch later today (if i get time, or sometime next week if i don't, i'm' kind of busy lately)
too late... i already fixed it... it was a missing "=" that was screwing up the nested if else's in the context menu :)
and i found that edit title doesnt work 100%. the title is kept in two places: the database in movieinfo table, and in the imdb cached xml file for the movie (in albums/imdb/tt#######.xml). you're only updating the database piece. the function edits the title thats displayed in the listing, but its not propogated into the info window.
MercuryInc
2005-10-17, 01:42
i'll get the cvs tomarrow then, and i'll submit the overlay patch with the feature alreaday added. i'll remove the "w" and take a whack at making a setting to be able to switch the show mode to global (its just two sides of the same coin on that one, so its probably better to have a setting for it)
i'll get the cvs tomarrow then, and i'll submit the overlay patch with the feature alreaday added. *i'll remove the "w" and take a whack at making a setting to be able to switch the show mode to global (its just two sides of the same coin on that one, so its probably better to have a setting for it)
is my idea about flags possible or viable?
MercuryInc
2005-10-17, 06:42
yeah, i'll add multi-flags when i add multi-category
your probably right at that point it wouldn't make much since to still have watched and unwatched, since you could very well make those as categories. i'll put some thougt into it.
yeah, i'll add multi-flags when i add multi-category
your probably right at that point it wouldn't make much since to still have watched and unwatched, since you could very well make those as categories. *i'll put some thougt into it.
well, thanx. i hope to get the cvs soon :-)
categories really complicate the overlays. technically, you'd need an overlay per category when showing all videos.
MercuryInc
2005-10-18, 18:43
i agree, and since i had planned on making the categories dynamic i think i'm going to hold off for now. i downloaded the 2005-10-17 cvs last night and i'm adding the overlay code to it. i'll submit it tonight (hopefully) its a quick 3 file fix. i modified the fileitem to have a m_bchecked that is populated from the bwatched field, then in the guilistitem and guithumbnailpanel i watch for the value and if its true and its a video window and showall = 0 then i draw the overlay. (i decided not to draw an empty overlay over the unwatched to save a little memory and time, so overlays are only drawn on watched movies in showall sections)
(btw as a side note, now that i've got the overlay thing down, i'm thinking about adding offline content and adding an overlay that shows its offline. then when you go to play it, you get a prompt to insert a disk number, or something) (maybe this goes in a separate post?)
very nice. i cant wait to see this. two questions... where are the overlays drawn in thumb view and in listview? and are the overlays in memory for those items currently not on screen? we save memory by unloading the icons for items not currently on the screen.
i totally fscked everything up after adding cimdbmovie to fileitem. i had to revert back all the changes to fix it. i kept copies and will attempt to retry it maybe this weekend.
the overlay for offline media sounds cool. you could show an overlay image of a disc to depict offline media. oh, and i think xbmc already prompts the user for the correct disc if its not in the drive.
now i have the 17-10 build. i have to be really dum, as i can not find a trace of the new things, like new menu items for marking it is watched and new views... i drank some wine but... not that much.
just my $0.02...
i'd like to see the overlays only on the text, not the video/movie image itself. i think that having it only on the text portion will make it look cleaner.
my thought is to enable a clean look that allows for multiple "watched" at once you'd use multiple colors and it would be something like this (please forgive the quick mspaint mockup)...
http://members.cox.net/affini/watched_example.jpg
MercuryInc
2005-10-18, 19:39
jerry: *make sure you have gone to the title section and have movies added to the db (look at previous posts if you still need help, i think mid-page 4 ish)
they are drawn in the render function in listview and renderitem in thumb. *i didn't add the overlay to the class because i want to conserve memory.
no, overlays for non-displayed icons are not in memory. (they are actualy removed from memory after being rendered)
i added a bool field to the fileitem ok, so maybe i can take a crack at adding the cimdbmovie item, i'll see what i come up with.
if it already prompts for a disk, can you tell me what field i use to detect if its online or offline?
affini:
i dig the idea, have a look at the overlay in the next couple of days and see if you still feal that way. its pretty unintrusive by my standards anyways. the other thing i was thinking about was making it an underlay so that it just gets a border of red or blue if its watched. just some ideas. keep the thoughts coming
cool... cannot wait to check it out!
i have to read instructions of xbmc i guess. i always used the fies view, i see the all and watched in title view but i don't know how to add movies. i thought this would work on the files menu. i have to learn about the other ones.
MercuryInc
2005-10-18, 21:13
it doesn't work on the file view because the file view isn't stored in the db. all you need to do is right click (white button) the movie you want to add to the db and click (green button) on movie information. it will search through imdb and give you a list of titles to select from. select the title you want and it will bring up a thumbnail and other info (at this point it is in the database with an unwatched status) now switch to title view and you should see just that one movie.
and watched and unwatched will work for it.
rinse and repeat for all movies you want to
geee, this is the only way, can't i scan the folder and add the movies? i have some shows that are in slovenian language, they are not in imdb at all. and about 50 columbo shows. there is no way to add them to the database?
i thought this was stored in a database somehow from file view, because i can resume every movie that i started watching at one time. so there must be something that is stored somewere.
MercuryInc
2005-10-18, 21:23
bookmarks are stored in the db, but not movieinfo (which is the table that holds bwatched values)
yes you can scan the folders but i think the skin by default doesn't show the scan button anymore.
look in the skin folder you are using and you'll find a line like this
<control>
<description>scan</description>
<type>button</type>
<id>8</id>
<posx>50</posx>
<posy>305</posy>
<label>102</label>
<onleft>50</onleft>
<onright>50</onright>
<onup>7</onup>
<ondown>9</ondown>
<visible>no</visible>
</control>
change <visible>yes</visible> and you should be able to see a button called scan. enter the folder you want to scan and press the button.
(the scan feature isn't that great but it should work for your purposes.) it will probably assign the default thumbnail for your files (if they arn't in imdb) but they will still show up in the titles section. if they have the wrong name use the edit name feature.
(anyone else got any sugestions for jerry here?)
i added a bool field to the fileitem ok, so maybe i can take a crack at adding the cimdbmovie item, i'll see what i come up with.
what annoys me is i actually had it working for while. i even added a cfileitem constructor which took a cimdbmovie as the input for simplicity. i'm not sure when it broke, but it was pretty bad. give it a try if you like but i'm warning you that adding the entire cimdbmovie object into cfileitem as a member isnt as easy as adding a single boolean. first the object needs class inheritance from iserializable for writing the object to disc cache. and its also missing proper constructors and destructors and some other things. if you give it a try, use musicinfotag as a template.
if it already prompts for a disk, can you tell me what field i use to detect if its online or offline?
again, i'm 100% sure, but i *think* it prompts for disc. could someone who has scanned media off the dvd drive confirm this? and i dont know what it uses to detect this but my guess would be m_strpath. if the path is d:\ or iso9660:\ or udf:\ then its assumed to be a disc.
i have a majority of my media on dvd-r and yes you can give them unique volume names and it will ask for them.
apologies : i take it back i cannot even get the media to show a thumbnail now in titleview if its on dvd. arghhhhh! http://www.xboxmediaplayer.de/forums/non-cgi/emoticons/cry.gif
MercuryInc
2005-10-18, 22:33
:) i'm scared off from putting it in now. i didn't realize the serializable stuff.
what i was actualy thinking about doing is allowing imdb searches to be inserted into the database without a base folder. *(basicaly if you had a numbered dvd collection this would be usefull so you never have to get each dvd out and put it int the drive) i was planning on useing the movie.cdlable to store the disk number, and the path to store a short description of where it is stored. *then the prompt could be something like "please insert cd#" + movie.cdlabel + crlf + "it can be found in location " path.strpath
that would also allow you to keep offline collections of other peoples movie. *basicaly "please insert cd# 137" "ite can be found in location: john's house" or "..location: shelf 1 of book case 2" *whatever.
*edit*
hey deanr can you do it without putting the dvd in? or do you have to insert each disk and scan it before it will prompt? (baasicaly i mean can you add the media from an imdb scan)
yeah, tell me about it. i didnt realize how it involved it was until i started doing it. i'm still quite annoyed because i had the damn thing working for a day or two until i totalled fscked it up.
interesting concept but i think it would be better if we had a little pc app which would allow users to (1) easily edit an existing database, and 2) add items directly to the database which is effectively what you're looking to do. the text entry is alot easier on the pc than on the xbox since most users do not have an xbox keyboard. the custom text could be accomplished with an additional field strlocation field in the database.
a warning... you need to use a specially compiled version of sqlite3.dll. we modified one constant in the sources to match the clustersize of the fatx filesystem, and of course, this value is out of spec with the standard sources. the xbmc compatible dll is in cvs though :)
on a side note, i had to start using sqlite spy. i was using sqlite explorer for a long time until i recently found a bug in how it handles date and time fields. since the music database now has a last played field, i had to swich to sqlite spy.
MercuryInc
2005-10-18, 22:53
the thought i had was just to add the member, and not use it unless it is populated, there is an = overload for cimdbmovie right? if there is you should be able to pass the object, and if you are in movie windows use the member, and if not dont. (don't know if that takes care of the serilaze problem or not, no experince there)
no freakin kidding;) it took me 2 weeks to figure out what the hell was wrong with my databases:) i'll have a look at sqllite spy.
i like the idea of a desktop app. that is how mymovies for mce works.
i'll tell you the truth, i think the whole database cimdbmovie idea needs to be reworked and the data consolidated to one place (either no xml files or no db). most data is stored in 2 places. and i personaly hate having to add my movies back in every time someone makes a change to the db.
bookmarks are stored in the db, but not movieinfo (which is the table that holds bwatched values)
yes you can scan the folders but i think the skin by default doesn't show the scan button anymore.
look in the skin folder you are using and you'll find a line like this
* * *<control>
* * * *<description>scan</description>
* * * *<type>button</type>
* * * *<id>8</id>
* * * *<posx>50</posx>
* * * *<posy>305</posy>
* * * *<label>102</label>
* * * *<onleft>50</onleft>
* * * *<onright>50</onright>
* * * *<onup>7</onup>
* * * *<ondown>9</ondown>
* * * *<visible>no</visible>
* * *</control>
change <visible>yes</visible> and you should be able to see a button called scan. *enter the folder you want to scan and press the button.
(the scan feature isn't that great but it should work for your purposes.) *it will probably assign the default thumbnail for your files (if they arn't in imdb) but they will still show up in the titles section. *if they have the wrong name use the edit name feature.
(anyone else got any sugestions for jerry here?)
well, i tried... and i am very dissapointed. not by you mercuryinc, you did great. but in the way xbmc is put together :-( i can indeed put every single file to be scaned. but then it wants to look in imdb and i have 50 columbo series. it makes all of them the same name (columbo murder by night 1970). it obviously can not just scan like copy file info in the database... it wants to connect to imdb to get things done...
i unghosted the scan button but it doesn't work. it scans 5 columbos instead of 50 and it doesn't put them in the database... i would need an option to copy file files from file view to the database view.
i have one question though. is it impossible or nearly impossible to make so that the w or the flag would be in file view, so in different database as you told me? if there could be resume movie, there could also be a flag i guess. but that makes at least double the work.
i can understand if one has a movie database to scan by imdb every one of them to make a database collection. but if you have recordings from tv or local tv movies/shows not found in imdb that option is nearly useless :-( and worst thing is, i don't think it can be "fixed", as the xbmc is made that way i guess...
@mercuryinc
i hear ya. its annoying that the information is in two places. iirc, most of the data was moved off to the xml files because of some limitation with the text fields in the database. but yes, i agree that any particular piece of information should only be in one place, and not duplicated like the title.
i've also been thinking about allowing moviename.xml files found alongside movies to be imported during a scan to avoid having to consult imdb.
@jerry2
the only way to work around this is to clean up your filesystem. if you have movies in one location, and tv shows in another, you can scan movies, but not scan tv shows.
your colombo videos are definately in the database. they probably got stacked into five unique stack groups, and then imdb returned something completely wrong. if you open up your database with sqlite spy, and use the sqlite3.dll found in cvs, you can check. look at the files table and work backwards from there.
@mercuryinc
i hear ya. *its annoying that the information is in two places. *iirc, most of the data was moved off to the xml files because of some limitation with the text fields in the database. *but yes, i agree that any particular piece of information should only be in one place, and not duplicated like the title.
i've also been thinking about allowing moviename.xml files found alongside movies to be imported during a scan to avoid having to consult imdb.
@jerry2
the only way to work around this is to clean up your filesystem. *if you have movies in one location, and tv shows in another, you can scan movies, but not scan tv shows.
your colombo videos are definately in the database. *they probably got stacked into five unique stack groups, and then imdb returned something completely wrong. *if you open up your database with sqlite spy, and use the sqlite3.dll found in cvs, you can check. *look at the files table and work backwards from there.
but how can i import tv shows into database if i scan only movies? i mean i usually know which movie i have watched and which i haven't. but i am stuck if i have watched columbo 27 or it was 26.
MercuryInc
2005-10-18, 23:20
kraq and i have just been discussing an external application to allow file insertion from an appliction in windows. if i end up doing this app it will most definently have the ability to scan and just use the file names. i also am not way impressed with the scanning ability. also, what i did for my tv series is added them one by one, and manualy changed the name to the disk and episode i wanted. e.g. simpsons is what imdb found and i changed it to simpsons episode 1 season 1 (i also got a picture with the simposns for that particualr tv series)
the limitation is that current database is not designed to handle tv shows. i really discourage you from scanning tv shows, but if you insist on scanning them because you want the watched status, you'll need to do some work.
first, ensure that the episodes do not stack. this will require you to either rename the files, or change the stacking regexps. after you confirm they do not stack, scan them. they should then be added as individual items. then, you'll need to manually edit the titles because who knows what imdb will return.
the limitation is that current database is not designed to handle tv shows. *i really discourage you from scanning tv shows, but if you insist on scanning them because you want the watched status, you'll need to do some work.
first, ensure that the episodes do not stack. *this will require you to either rename the files, or change the stacking regexps. *after you confirm they do not stack, scan them. *they should then be added as individual items. *then, you'll need to manually edit the titles because who knows what imdb will return.
hi there
i can certanly understand that the database does not handle tv shows ok... but the watched status is mostly used for tv shows not for moviw imho, because i forgot what show i last watched and i still know what moview i have looked already.
i would very much like a feature that would put all the filenames into the database, just as simple as that. maybe that is a hard thing to do, i am no developer :-(
hi!
very happy about this new feature.
but the button in the gui (all videos/watched/unwatched) should behave like the "libary view" button. i mean that you could switch state with left/right an not by clicking "a"
cu lolol
MercuryInc
2005-10-19, 18:33
jerry, i have a present for you. it turns out that the db is queried to see if there are images related to files and folders on shares, which means the files view can have the watched and unwatched feature. you still must put the movies in the database with scan or by right clicking each file but it is a step. you also won't be able to filter for just watched and unwatched but i got the overlay working last night. you'll have to be patient for a few more days, i'm a little busy and i've got to optimize it so it doesn't slow stuff down.
kraq:
had no problem implamenting the cimdbmovie item into cfileitem. i didn't serialize it, i just added the member and populate it in each of the movie views. there was no significant memory use. what is the value of serializing, i can't see any problem with not serializing certain members. let me know what you think.
@merc
thats one way, but not necessarily the correct way. some functions cache the entire cfileitemlist to disc. i'm not sure what will happen if that object is not serialized along with the others when that happens. the best case is this information is just not returned when the list is read back again from disc. the downside to this is now the items are missing information.
watched and unwatched status is kept for a "movie", not a file. what happens in files view when a "movie" has more than one file? do they all get the overlays?
and i think the overlays should be a configurable option, for files view at least.
@jerry2
yes i understand that you believe that the watched status is most useful for tv shows. but, the reality is that the watched status is for items in the database, and the database was not meant for tv shows.
MercuryInc
2005-10-19, 19:21
that is true, the info would be lost if it is cached, but as far as i can tell the video windows don't seam to flush it to disk (maybe it gets flushed when windows are switched?) its a bit of a hack that works for now, until we can get it to serialize.
the way i apply movie information to files is this:
currently if a path has an image associated with it, the db is queried anyways, so i just added the bwatched field to the same query, then when the directory is updated it only applies overlays to files that have thumbnails accociated with it. (same effect as when in title view. only images in the db get overlays, it is just implied that files that arn't in the db woun't show up in the title view) basicaly the getmoviesbypath function was just returning the xml file name so the setimdbthumbs function could apply the appropriate icon to the folder, i just told getmoviesbypath to also return file name, path, and bwatched
i agree with the configurable option only if there is a preformance impact. since the db is accessed anyways, we might as well apply the overlay?
let me know what you think.
good point. those files which are in the database get their image based on the associated imdb number. in that case, i wouldnt even bother with making it an option.
can you please oh please change that
(that thumbs use imdb numbers) =)
makes the system might inflexible imho
MercuryInc
2005-10-19, 22:51
post an alternate solution and i'll have a look at it. (its pretty ingrained right now though so don't expect to much with the overlay patch release)
jerry, i have a present for you. *it turns out that the db is queried to see if there are images related to files and folders on shares, which means the files view can have the watched and unwatched feature. *you still must put the movies in the database with scan or by right clicking each file but it is a step. *you also won't be able to filter for just watched and unwatched but i got the overlay working last night. *you'll have to be patient for a few more days, i'm a little busy and i've got to optimize it so it doesn't slow stuff down.
kraq:
had no problem implamenting the cimdbmovie item into cfileitem. *i didn't serialize it, i just added the member and populate it in each of the movie views. *there was no significant memory use. * what is the value of serializing, i can't see any problem with not serializing certain members. *let me know what you think.
thanx, great present... great news. now only if database scan could turn out to be "filenames to database" somehow :-)
@jerry2
yes i understand that you believe that the watched status is most useful for tv shows. *but, the reality is that the watched status is for items in the database, and the database was not meant for tv shows.
it would be most usefull for me at least. i am not sure how others think. but it is irellevant as long that the db is made for movies primarly. maybe just to think about expanding the idea :-)
and i don't care about databasing tv shows, just to add them simply from file menu to database without imdb and automatically leaving filenames so i would have a duplicate in title view same files as i have in files view now :-) nothing more. but i guess it is not meant to be this way easily.
even better, adding watched item to file view :thumbsup:
actually, it would be trivial at this point to mark a "file" as watched and unwatched in addition to marking a "movie". whenever a file is played, its added to the files table so that video settings can be saved per file.
then in files view, the marking could come from the file table, and in the db views the marking could from the movieinfo table.
and spiff... i cant agree with you more. everywhere else xbmc use a crc of the path to determine the thumb, except in videos.
yeah, crc32 or some (other) kind of hashing would do the trick just fine.
i compiled xbmc and i don’t see this feature appair on the xbox…
i thought this was already in cvs …….
my guess is that i will need to apply the patch1.1 file ‘s to my skin?
MercuryInc
2005-10-23, 21:29
the skin files in the patch won't work with the cvs. but if you didn't deploy the skin folder with the new build then just copy the skin folder over (you could even name it something different and give it a try before you add it to your prefered skin)
also, read back through the post and make sure that you are not in the files section of my videos
thanks mercuryinc it works, unfortunately not the way i expected, reading trough this topic i saw that it was already discussed that this is missing in the file menu. i also store a lot of tv show. we here are not using the database view at all, it’s too hard for my family members and i find there all the double movie names…..
i really hope this great option will evolve into the file menu as well…
thanks mercuryinc it works, unfortunately not the way i expected, reading trough this topic i saw that it was already discussed that this is missing in the file menu. i also store a lot of tv show. we here are not using the database view at all, it’s too hard for my family members and i find there all the double movie names…..
i really hope this great option will evolve into the file menu as well…
my wishes up also for it :-) :bowdown:
is there a way to scan my movies without retriving info from imdb?
i just want to be able to scan my files and then use the watched/un-watched option...
like it is now it takes forever to scan and if imdb dosnt find right movie it picks one that often is wrong... *:(
it would be great if i scan and show them as filename and then be able to set the [w] for watched. that way i know where i am if i watch a season of a tv-show.
or even better... if i select watched from the context menu xbmc would add [w] at the end of the filename. family guy s03e13.avi would be named family guy s03e13 [w].avi and un-watched would remove it from the filename...
DocSnyd3r
2005-11-25, 14:30
hi,
i thought in the new images you are able to see whitch files you have already watched. but i can't find this feature anywhere, do i need a special skin for this to work?
LaTropa64
2006-03-16, 01:30
i like the watch and unwatched views that you can switch to under my videos but i'm wondering if it's suppose to automatically mark a movie as watched once you view it? mine doesn't. i have to remember to go in after watching the movie and marking it as watched. i'm using the 2006-03-12 t3ch build.
no, its intentionally not automatic. you need to manually mark movies as watched.
LaTropa64
2006-03-16, 10:56
:cool: i wasn't sure. thanks for the reply.
jmarshall
2006-03-16, 21:24
why is it not automatic as well as being manual? if automatic detection of a watched movie was added, you can easily change it again to unwatched if you want to.
i'm likely missing something...
LaTropa64
2006-03-16, 22:10
yeah, i think it should be automatic too. i know nothing about coding though and maybe it would just take too much work because of all the different ways people would want it to automatically handle it.
i wouldn't want it to be marked as watched if i just started playing it and than immediately stopped it. i probably also wouldn't want it to be marked as watched if i only made it half-way through the movie. for an automatic flag to still be worthwhile it would need to only mark it as watched if i've played at least 90% of the movie or so.
jmarshall,
the discussion is still in the development forum, but i believe it was something along the lines of "how far into a movie do we mark it as watched?" since there was no clear answer, its still manual. but, i agree. this could easily be automated.
jmarshall
2006-03-16, 22:56
ah - yep, the issue is always "when do we mark as watched (or played for songs)".
this is complicated by the fact that we can ffwd, rewd and seek within movies.
perhaps it should be marked as watched if it gets within say 10% of the end of the movie when playback ceases?
we could have it as part of the "advanced settings" structure (ie xml only) as a percentage of the movie length would work quite well i think (means people can press stop at the credits and it'll still work)
cheers,
jonathan
don't we increment the "played" counter for a song as that song starts? if so, i think it would be easier to apply the same logic to movies, with a simple boolean option of "automatically mark movies as watched". i'd even just default it to true as it seems to be expected.
please dont flame me for not knowing what i'm talking about.
i've been wanting a feature like this watched/unwatched thing for a long time. for me, this would be most useful for tv shows, so i know which episodes have been watched. because of the way my tv shows are set up, i use file view, not title view for all video files. my question is, is it possible to have a watch/unwatched flag in file view? to me it seems that it would be hard/almost impossible to implement this, as i assume file view does not utilise the database at all.
and i haven't really spent much time in title view, but i assume this view is not good for multiple series of tv shows.
jmarshall
2006-03-17, 00:23
no, it doesn't (and won't) work in file view.
we've been wanting to generalise the video database for a long time, but as you know, these things take time, something we don't have a lot of.
one day it will be done.
cheers,
jonathan
jmarshall
2006-03-17, 01:41
ok, it's in cvs now.
it operates by default at 90% of the movie length.
the same now applies to songs.
you can set the % in settings.xml
cheers,
jonathan
LaTropa64
2006-03-23, 15:02
ok, it's in cvs now.
it operates by default at 90% of the movie length.
the same now applies to songs.
you can set the % in settings.xml
cheers,
jonathan
would this have been in the 2006-03-20 t3ch cvs? i noticed the last movie i finished didn't automatically switch to watched.
also, where's the settings.xml suppose to be? i found a couple under the skins folder but they just look like files to set where icons are located and such. i couldn't see anything about adjusting the percentage.
jmarshall
2006-03-23, 22:03
it was put into cvs when i posted.
the setting is:
<playcountminimumpercent>
in settings.xml (e:\tdata\0face008)
LaTropa64
2006-03-24, 04:03
it was put into cvs when i posted.
the setting is:
<playcountminimumpercent>
in settings.xml (e:\tdata\0face008)
thanks!
i went and started a bunch of movies, seeked to near the end and than stopped them and it does work, for the most part anyways. on any of my movies that are stacked and split it into two files it won't automatically change the watched flag. it didn't matter if i stopped it towards the end of the first file, second file (or in one case third file). i'm guessing this is probably a good thing though because i think a lot of people use the stacking feature to store tv show episodes in the database without having 20 different icons for each show.
diagdave@msn.com
2006-03-30, 10:25
why do we need to switch to database view for this to work? can't we have it work in files view? afaik the files still are i in the database for things like "resume" and video settings. so couldnt this work for folder view as well?
could; yes.
should; no.
when the db views gets better in my videos, the file view will probably behave like file view does in my music; only filenames no additional db info.