PDA

View Full Version : Cguitextbox 50 page limit


Bernd
2005-05-25, 02:26
in the file xbmc/xbmc/guilib/guitextbox.cpp
inside the c'tor there is a limit of 50 pages.
m_imaxpages = 50;
is this value of 50 there for a special reason or was is just set as a should be enough value?

it would be nice if it could be increased (doubled, better tripled or dropped completely ;)) if it doesn't cause any sideeffects, besides memory usage.

i quickly reviewed the class and couldn't find anything, since cguitextbox::render only renders the visible lines. so the runtime of it should be equal.

i've created a python script that displays gamefaqs and walkthroughs.
when reading long texts i.e. the halo2 faq which is about 280k of text, the user can only read half of the text due to the 50 page limit.

cheers
bernd

jmarshall
2005-05-25, 09:32
no reason that i can see, other than "that'll probably be enough".

will increase.

Bernd
2005-05-25, 23:48
great! :thumbsup:
i will monitor the changelog.